Closed Bug 293124 Opened 20 years ago Closed 20 years ago

useless initialization after memset in CMozillaBrowser::OnSaveAs

Categories

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Product:
Core Graveyard
Component:
Embedding: ActiveX Wrapper
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: mcsmurf)

References

(
URL
)

Details

Attachments

(1 obsolete file)

memset makes the entire structure null, why bother nulling out individual items afterward?
Attached patch Patch (obsolete) — — Splinter Review
Attachment #182793 - Flags: review?(timeless)
Attachment #182793 - Flags: superreview?(tor)
Attachment #182793 - Flags: review?(timeless)
Attachment #182793 - Flags: review+
Attachment #182793 - Flags: superreview?(tor) → superreview+
Attachment #182793 - Flags: approval1.8b3?
Comment on attachment 182793 [details] [diff] [review] Patch a=shaver
Attachment #182793 - Flags: approval1.8b3? → approval1.8b3+
Assignee: adamlock → bugzilla
fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 182793 [details] [diff] [review] Patch mozilla/embedding/browser/activex/src/control/MozillaBrowser.cpp 1.112
Attachment #182793 - Attachment is obsolete: true
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: