Closed Bug 293162 Opened 19 years ago Closed 19 years ago

InnerHTML on textarea shouldn't just treat the HTML as text

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: mrbkap)

References

Details

Attachments

(1 file)

We should be using the parser, but the skipped content mess prevents us.  Once
bug 272702 is fixed, we can probably remove this method from this class
altogether and just use the generic SetInnerHTML.
Blocks: 292839
Blocks: 215228
Depends on: 208869
Not quite doable yet because the <body> hack (which may be removable once bug
289537 is fixed) gives a random <body> string in the textarea.  That, plus
tokenizer weirdness leading to nested textarea tags in the resulting DOM...
Depends on: 289537
Depends on: 296677
Depends on: 265367
No longer depends on: 272702, 289537
Attached patch patch v1Splinter Review
This isn't quite ready for review/check in, but it's getting close so I wanted
to attach the patch that fixes this bug for good.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Depends on: 152329
No longer depends on: 265367
Comment on attachment 185699 [details] [diff] [review]
patch v1

All of the dependencies are fixed. I've tested, and this doesn't regress
anything too noticeably (i.e., I didn't see anything bad happen). It'd be nice
to get this in pretty soon.
Attachment #185699 - Flags: superreview?(jst)
Attachment #185699 - Flags: review?(bugmail)
Attachment #185699 - Flags: review?(bugmail) → review?(peterv)
Attachment #185699 - Flags: review?(peterv) → review+
Comment on attachment 185699 [details] [diff] [review]
patch v1

sr=jst
Attachment #185699 - Flags: superreview?(jst) → superreview+
Comment on attachment 185699 [details] [diff] [review]
patch v1

This finally fixes textarea's innerHTML to not be broken. It should go in now
so as to get the maximum amount of testing possible.
Attachment #185699 - Flags: approval1.8b3?
Comment on attachment 185699 [details] [diff] [review]
patch v1

a=shaver
Attachment #185699 - Flags: approval1.8b3? → approval1.8b3+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: