293225 - Default height of CANVAS should be 150

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Anne (:annevk)]

I believe this recently changed from 200, but I guess Hixie had his reasons.
 <http://whatwg.org/specs/web-apps/current-work/#canvas>

See also bug 291216 comment 39. Patch coming up.

Comment 1

[Anne (:annevk)]

Attachment: change 200 to 150

Comment 2

[Hixie (not reading bugmail)]

The reasoning was that these numbers should match the <iframe> default size.
Please check that they are the right numbers to do this when checking in.

Comment 3

[Anne (:annevk)]

<iframe src="data:text/plain,PASS">FAIL</iframe>
<script>alert(window.getComputedStyle(document.getElementsByTagName('iframe')[0],null).height);</script>

... returns 150px for me. And when replacing 'height' with 'width' I get 300px
so that seems to be ok.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 182848 [details] [diff] [review]
change 200 to 150

please don't request approval until you've got sufficient reviews. thanks.

Comment 5

[Boris Zbarsky [:bzbarsky]]

"What Does Apple Do?"

Comment 6

[Hixie (not reading bugmail)]

They require height/width and have no error handling behaviour if they are missing.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I rolled this patch into the patch in bug 293407.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Checked in as part of bug 293407.

Comment 9

[Jesse Ruderman]

reftest: http://hg.mozilla.org/mozilla-central/rev/2113cb711b09