293453 - Unable to click link when inside div with overflow:auto and border-top

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
I am unable to click on the top link using current trunk build.
It seems directly related to the border-top-width of the overflow:auto div, as
the second link is partly clickable when the border-top-width is 10px.
The bug also happens with overflow:scroll divs.

It doesn't happen with 2005-04-03 build, it happens with 2005-04-04 build:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-03+06%3A00%3A00&maxdate=2005-04-04+09%3A00%3A00&cvsroot=%2Fcvsroot
I very much suspect bug 288117 to be the culprit.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The problem is that the scrolled frame's mRect is at (0,0) but the event point
(relative to the scrolled frame's parent frame's nearest view) is at 50px +
whatever so nsBlockFrame::GetFrameForPointUsing decides that the event is
outside the frame. Unfortunately fixing this without regressing anything looks
really hard so this patch just hacks around the problem by marking the scrolled
frame as having outside children. Then because the scrolled frame has a view,
it corrects the event to the right coordinates for its children.

This is lame but I can't think of anything better short of fixing all the event
code to use reasonable invariants, and we don't have time to do that for this
release.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183119 [details] [diff] [review]
fix

r+sr=bzbarsky, but file a bug to remove the hack (dependent on the event coord
bug)?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 183119 [details] [diff] [review]
fix

fixes event handling regression. takes a safe(r) but hacky approach

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 183119 [details] [diff] [review]
fix

a=asa

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is there any code that gets confused because there's no overflowAreaProperty
frame property?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I checked the nsFrame code, specially nsFrame::GetOverflowRect, and it looks OK.

Comment 9

[Peter van der Woude [:Peter6]]

appears to have caused Bug 294324

Comment 10

[jag (Peter Annema)]

(In reply to comment #3)
> r+sr=bzbarsky, but file a bug to remove the hack (dependent on the event coord
> bug)?

What's the bug number for that?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Well, I forgot to file it. But now it's bug 295941.