293543 - RenderOffscreen creates an overlarge drawing surface

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

nsViewManager::RenderOffscreen creates a drawing surface with dimensions given
in twips, but it should pass pixels. This creates a massive offscreen bitmap
that we only use a small part of --- wasting resources and risking allocation
failures.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

trivial fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Thanks to James Linden for detecting this, by the way.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183100 [details] [diff] [review]
fix

r+sr=bzbarsky

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 183100 [details] [diff] [review]
fix

trivial fix with zero risk since this code is not used by regular users

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183100 [details] [diff] [review]
fix

a=shaver.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 7

[Peter van der Woude [:Peter6]]

(In reply to comment #6)
> checked in

any chance it is causing 
http://forums.mozillazine.org/viewtopic.php?p=1451607#1451607 ?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I shouldn't think so. That code should not be executed at all by normal users.

Comment 9

[Peter van der Woude [:Peter6]]

(In reply to comment #8)
> I shouldn't think so. That code should not be executed at all by normal users.
very odd, a few builds later and it's normal again.