293664 - Temporary network's secure/non-secure properties don't get updated when trying to reconnect

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

Trying to connect to a server using a secure connection fails if you connected
to the same server before using a normal connection.

Steps to reproduce:
1. /attach irc.mozilla.org:6697
2. Watch it fail, since you're trying to attach normally using a port which is
only available for SSL connections (note that not all secure servers will behave
this way).
3. /attach ircs://irc.mozilla.org:6697
4. Watch it fail, saying this network does not have secure servers.

To fix this, cmdServer and cmdSSLServer need to cope with temporary networks
differently. Patch coming up.

As a workaround, you can close ChatZilla and reopen it, or manually set
e.network.primServ.isSecure to true.

Comment 1

[:Gijs (he/him)]

Attachment: Patch

Patches cmdServer and cmdSSLServer to set the primServ's isSecure bit correctly
if the server is temporary.

Comment 2

[James Ross]

Comment on attachment 183193 [details] [diff] [review]
Patch

r=silver

Comment 3

[:Gijs (he/him)]

Comment on attachment 183193 [details] [diff] [review]
Patch

Requesting approval for harmless CZ patches

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183193 [details] [diff] [review]
Patch

a=shaver

Comment 5

[James Ross]

Checked in -> FIXED.