293818 - [FIXr]Need document API for deferring onload

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

We've discussed this a few times, and I've run into really needing it for some
work I'm doing, so I went ahead and put this together...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

This is a really basic impl; we may want to make BlockOnload() be a no-op if
onload has already fired, but that's something I'd be leery of trying to do in
1.8....

Comment 2

[Darin Fisher]

Why does nsOnloadBlocker need a mLoadGroup member variable?  Who calls
SetLoadGroup/GetLoadGroup on it?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm... Apparently no one.  I thought adding to the loadgroup did...

Should I be setting it before I call AddRequest on the loadgroup?  We seem to do
that for our current dummy layout requests.

Comment 4

[Darin Fisher]

I don't see any reason for this request to have a loadgroup of its own. 
Normally, one sets a loadgroup on a request, so that that request will
automatically add and remove itself from the loadgroup when it starts and
finishes.  In this case, you are manually adding/removing the request to/from
the loadgroup, so there is no need to tell the request about the loadgroup ;-)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  Sounds good.  Consider that member and the relevant code removed.  ;)

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 183324 [details] [diff] [review]
Proposed patch

sr=jst

Comment 7

[Darin Fisher]

Comment on attachment 183324 [details] [diff] [review]
Proposed patch

r=darin w/ the loadgroup cruft that we discussed removed.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch updated to comments

Requesting 1.8b2 approval... This is a pretty safe patch that shouldn't change
any existing behavior but should make some other changes I'm still aiming for
for 1.8 much simpler.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 183424 [details] [diff] [review]
Patch updated to comments

a=asa

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Merged to tip

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this allow replacing the DummyLayoutRequest?  If so, could you file a bug
on that?

Comment 13

[Boris Zbarsky [:bzbarsky]]

That was one of the goals, yes.  For 1.9, I'd like to try.  Bug 294114 filed for
the layout request, and bug 294115 filed for the parser request.