294192 - [nit] Having prefs without label and help info with group == hidden still spams the console

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[:Gijs (he/him)]

When starting ChatZilla with the console open, 4 warnings are given every time
you start it:
WARNING: !!! Preference without label: urls.list
WARNING: Preference without help text: urls.list
WARNING: !!! Preference without label: urls.display
WARNING: Preference without help text: urls.display

To fix those (and make a general fix), the pref manager should check whether
group == 'hidden' before making these warnings.

Patch coming up.

Comment 1

[:Gijs (he/him)]

Attachment: Patch to take the group into account before spewing warnings

This takes care of the warnings, and should still do so for any subsequent
hidden prefs.

Comment 2

[:Gijs (he/him)]

Comment on attachment 183606 [details] [diff] [review]
Patch to take the group into account before spewing warnings

Requesting approval for harmless CZ patches

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183606 [details] [diff] [review]
Patch to take the group into account before spewing warnings

a=shaver

Comment 4

[James Ross]

Checked in -> FIXED.