294402 - Change unnecessary assertions in nsParser.cpp to warnings

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

In bug 220542 comment 28, Brendan asked me to change the assertions that I added
in the patch to that bug into warnings if the code could handle them. At the
time, I didn't want to because they were firing at unexpected times (as well as
the expected ones). It looks like the patch in bug 284587 fixed the unexpected
assertions, so I'll attach a patch to change them into warnings.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

This simple patch changes the assertions into warnings.

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 183774 [details] [diff] [review]
patch v1

r+a=me, looks good -- glad this got sorted out.

/be

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 183774 [details] [diff] [review]
patch v1

>Index: src/nsParser.cpp
>+  if (!(mFlags & NS_PARSER_FLAG_PARSER_ENABLED)) {
>+    NS_WARNING("Don't call ContinueInterruptedParsing on a blocked parser.");
>+  }

Make this whole if #ifdef DEBUG.

sr=bzbarsky with that.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.