294507 - mozilla-config and mozilla-nspr.pc is not populated correct if compile-option --with-system-nspr is used

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

mozilla-config and mozilla-nspr.pc is not populated correct if compile-option
--with-system-nspr is used:

- mozilla-nspr.pc has almost hardcoded cflags
- %FULL_NSPR_LIBS% and %FULL_NSPR_CFLAGS% were not replaced correctly
  because Makefile.in uses undefined $(NSPR_CONFIG)

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: proposed patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

Caillon should review this.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

Please get module owner approval or review first before seeking approval.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

Also, please remember to ask for 1.7.9 *AND* aviary-1.0.5 approval on patches
like this.  Its in core, and we NEED to keep the branches in sync.

Comment 5

[Benjamin Smedberg]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

moa=me, FWIW

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

the patch works for me but it throws an error while configure step. I don't know
what's wrong though?

creating Makefile
creating build/Makefile
creating build/unix/Makefile
Unknown variable:build/unix/Makefile:27:NSPR_CONFIG     = @NSPR_CONFIG@
creating config/Makefile
creating config/mkdepend/Makefile
creating caps/Makefile

Comment 7

[Wan-Teh Chang]

Wolfgang, isn't this your own patch? :-)

I don't know what's wrong.  In mozilla/configure, I
see a sed script that substitutes @NSPR_CONFIG@:

18586 s%@NSPR_CONFIG@%$NSPR_CONFIG%g

(see http://lxr.mozilla.org/seamonkey/source/configure#18586)

So I don't know why that substitution was not made.

What is that "NSPR_CONFIG = ..." line in the generated
build/unix/Makefile file?

Comment 8

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #7)
> Wolfgang, isn't this your own patch? :-)

yes

> I don't know what's wrong.  In mozilla/configure, I
> see a sed script that substitutes @NSPR_CONFIG@:
> 
> 18586 s%@NSPR_CONFIG@%$NSPR_CONFIG%g
> 
> (see http://lxr.mozilla.org/seamonkey/source/configure#18586)
> 
> So I don't know why that substitution was not made.
> 
> What is that "NSPR_CONFIG = ..." line in the generated
> build/unix/Makefile file?

The substitution works fine. Because all worked I found this error message that
late. For me it's just a cosmetical problem right now but I would be interested
in the reason for that.

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

moving request out to b3. We're very nearly wrapped up on 1.8b2.

Comment 10

[Mike Shaver (:shaver emeritus)]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

a=shaver for trunk

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 12

[Wolfgang Rosenauer [:wolfiR]]

> the patch works for me but it throws an error while configure step. I don't 
> know what's wrong though?
> 
> creating build/unix/Makefile
> Unknown variable:build/unix/Makefile:27:NSPR_CONFIG     = @NSPR_CONFIG@
> creating config/Makefile

do we need 
 AC_SUBST(NSPR_CONFIG)
in configure.in to avoid this warning?

Comment 13

[cls]

That @NSPR_CONFIG@ substitution should have gone into autoconf.mk instead of
that specific Makefile.  acoutput-fast.pl, which speeds up the Makefile
generation by only substituting @srcdir@ & @topsrcdir@ instead of all 400+
variables, is complaining about that unknown variable.

Comment 14

[Wolfgang Rosenauer [:wolfiR]]

Attachment: fix autoconf stuff

Comment 15

[Wolfgang Rosenauer [:wolfiR]]

hope that's OK. Thanks for the hint.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 183839 [details] [diff] [review]
proposed patch

1.0.5 and 1.7.9 have already shipped; removing approval requests.