Closed
Bug 294507
Opened 19 years ago
Closed 19 years ago
mozilla-config and mozilla-nspr.pc is not populated correct if compile-option --with-system-nspr is used
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wolfiR, Assigned: wolfiR)
Details
Attachments
(2 files)
1.12 KB,
patch
|
caillon
:
review+
|
Details | Diff | Splinter Review |
919 bytes,
patch
|
cls
:
review+
|
Details | Diff | Splinter Review |
mozilla-config and mozilla-nspr.pc is not populated correct if compile-option --with-system-nspr is used: - mozilla-nspr.pc has almost hardcoded cflags - %FULL_NSPR_LIBS% and %FULL_NSPR_CFLAGS% were not replaced correctly because Makefile.in uses undefined $(NSPR_CONFIG)
Assignee | ||
Comment 1•19 years ago
|
||
Comment 2•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch Caillon should review this.
Attachment #183839 -
Flags: review?(benjamin) → review?(caillon)
Updated•19 years ago
|
Attachment #183839 -
Flags: review?(caillon) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #183839 -
Flags: approval1.8b2?
Attachment #183839 -
Flags: approval1.7.9?
Comment 3•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch Please get module owner approval or review first before seeking approval.
Comment 4•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch Also, please remember to ask for 1.7.9 *AND* aviary-1.0.5 approval on patches like this. Its in core, and we NEED to keep the branches in sync.
Assignee | ||
Updated•19 years ago
|
Attachment #183839 -
Flags: approval-aviary1.0.5?
Comment 5•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch moa=me, FWIW
Assignee | ||
Comment 6•19 years ago
|
||
the patch works for me but it throws an error while configure step. I don't know what's wrong though? creating Makefile creating build/Makefile creating build/unix/Makefile Unknown variable:build/unix/Makefile:27:NSPR_CONFIG = @NSPR_CONFIG@ creating config/Makefile creating config/mkdepend/Makefile creating caps/Makefile
Comment 7•19 years ago
|
||
Wolfgang, isn't this your own patch? :-) I don't know what's wrong. In mozilla/configure, I see a sed script that substitutes @NSPR_CONFIG@: 18586 s%@NSPR_CONFIG@%$NSPR_CONFIG%g (see http://lxr.mozilla.org/seamonkey/source/configure#18586) So I don't know why that substitution was not made. What is that "NSPR_CONFIG = ..." line in the generated build/unix/Makefile file?
Assignee | ||
Comment 8•19 years ago
|
||
(In reply to comment #7) > Wolfgang, isn't this your own patch? :-) yes > I don't know what's wrong. In mozilla/configure, I > see a sed script that substitutes @NSPR_CONFIG@: > > 18586 s%@NSPR_CONFIG@%$NSPR_CONFIG%g > > (see http://lxr.mozilla.org/seamonkey/source/configure#18586) > > So I don't know why that substitution was not made. > > What is that "NSPR_CONFIG = ..." line in the generated > build/unix/Makefile file? The substitution works fine. Because all worked I found this error message that late. For me it's just a cosmetical problem right now but I would be interested in the reason for that.
Comment 9•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch moving request out to b3. We're very nearly wrapped up on 1.8b2.
Attachment #183839 -
Flags: approval1.8b3?
Attachment #183839 -
Flags: approval1.8b2?
Attachment #183839 -
Flags: approval1.8b2-
Comment on attachment 183839 [details] [diff] [review] proposed patch a=shaver for trunk
Attachment #183839 -
Flags: approval1.8b3? → approval1.8b3+
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•19 years ago
|
||
> the patch works for me but it throws an error while configure step. I don't
> know what's wrong though?
>
> creating build/unix/Makefile
> Unknown variable:build/unix/Makefile:27:NSPR_CONFIG = @NSPR_CONFIG@
> creating config/Makefile
do we need
AC_SUBST(NSPR_CONFIG)
in configure.in to avoid this warning?
Comment 13•19 years ago
|
||
That @NSPR_CONFIG@ substitution should have gone into autoconf.mk instead of that specific Makefile. acoutput-fast.pl, which speeds up the Makefile generation by only substituting @srcdir@ & @topsrcdir@ instead of all 400+ variables, is complaining about that unknown variable.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 14•19 years ago
|
||
Attachment #188407 -
Flags: review?(cls)
Assignee | ||
Comment 15•19 years ago
|
||
hope that's OK. Thanks for the hint.
Attachment #188407 -
Flags: review?(cls)
Attachment #188407 -
Flags: review+
Attachment #188407 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #188407 -
Flags: approval1.8b3? → approval1.8b3+
checked in
Assignee | ||
Updated•19 years ago
|
Status: REOPENED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
Comment 17•19 years ago
|
||
Comment on attachment 183839 [details] [diff] [review] proposed patch 1.0.5 and 1.7.9 have already shipped; removing approval requests.
Attachment #183839 -
Flags: approval1.7.9?
Attachment #183839 -
Flags: approval-aviary1.0.5?
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•