Closed
Bug 294685
Opened 20 years ago
Closed 20 years ago
Remove unnecessary counter/named entity code
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
37.85 KB,
patch
|
jst
:
review+
dbaron
:
superreview+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
In the HTML parser, there is a bunch of code |#ifdef DEBUG|ed out that handles
the <counter> tag, and <meta entity="foo" value="k">. The counter code
apparently was an attempt to implement something resembling CSS counters (using
<counter> somehow). The named entity code would allow the web page to define
entities, so given the tag above &foo; would turn into k.
Since the code is #ifdef DEBUG, and nobody uses it, I'm removing it. Patch in a
second.
|
Assignee | |
Comment 1•20 years ago
|
||
This simply removes the #ifdef DEBUG code, there should be no changes in non
DEBUG builds.
Attachment #183921 -
Flags: superreview?(dbaron)
Attachment #183921 -
Flags: review?(jst)
Attachment #183921 -
Flags: superreview?(dbaron) → superreview+
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•20 years ago
|
||
Comment on attachment 183921 [details] [diff] [review]
patch v1
r=jst
Attachment #183921 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 183921 [details] [diff] [review]
patch v1
This (mostly) DEBUG-only code removal is probably a good thing to go in for
1.8b3.
Attachment #183921 -
Flags: approval1.8b3?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 183921 [details] [diff] [review]
patch v1
a=shaver
Attachment #183921 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Fix checked in. Counters checked out!
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•