Closed Bug 294984 Opened 19 years ago Closed 19 years ago

Crash on data URI with unclosed iframe

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: mrbkap)

References

()

Details

Attachments

(1 file)

The URL in the URL field crashes today's build quite reliably.
I suck. There's an early return in ConsumeStartTag that doesn't enforce the
invarients that I try to.
Assignee: parser → mrbkap
Flags: blocking1.8b2?
Status: NEW → ASSIGNED
Attached patch patch v1Splinter Review
The early return was causing us to not create the text token and end tag, so my
assumptions in CNavDTD were being violated. This patch fixes the early return.
Note that Consume[Parsed]CharacterData() is protected from this case and deals
properly.
Attachment #184145 - Flags: superreview?(bzbarsky)
Attachment #184145 - Flags: review?(bzbarsky)
Attachment #184145 - Flags: superreview?(bzbarsky)
Attachment #184145 - Flags: superreview+
Attachment #184145 - Flags: review?(bzbarsky)
Attachment #184145 - Flags: review+
Comment on attachment 184145 [details] [diff] [review]
patch v1

This fixes a recent crash regression.
Attachment #184145 - Flags: approval1.8b2?
Severity: normal → critical
OS: Linux → All
Hardware: PC → All
Comment on attachment 184145 [details] [diff] [review]
patch v1

a=chofmann
Attachment #184145 - Flags: approval1.8b2? → approval1.8b2+
Fix checked in. Sorry for the inconvenience.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: blocking1.8b2?
QA Contact: mrbkap → technutz
Verified FIXED with build 2005-05-22-06 on Windows XP Seamonkey trunk.

Testcase: data:text/html,<iframe
Status: RESOLVED → VERIFIED
Depends on: 295520
No longer depends on: 295520
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: