Closed Bug 294989 Opened 19 years ago Closed 19 years ago

In <editorInlineSpellCheck.js>, 4 "Warning: anonymous function does not always return a value"

Categories

(Core :: Spelling checker, defect)

Product:
Core
Component:
Spelling checker
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta3

People

(Reporter: sgautherie, Assigned: mnyromyr)

Details

Attachments

(1 file)

trivially remove all unused return values [Checked in: Comment 4]
2.18 KB, patch
sfraser_bugs
: review+
dmosedale
: superreview+
benjamin
: approval-aviary1.1a2+
benjamin
: approval1.8b3+
Details | Diff | Splinter Review 
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050519] (nightly) (W98SE)

{{
Warning: anonymous function does not always return a value
Source File: chrome://editor/content/editorInlineSpellCheck.js
Line: 65, Column: 2
Source Code:
  },

Warning: anonymous function does not always return a value
Source File: chrome://editor/content/editorInlineSpellCheck.js
Line: 143, Column: 2
Source Code:
  },

Warning: anonymous function does not always return a value
Source File: chrome://editor/content/editorInlineSpellCheck.js
Line: 159, Column: 2
Source Code:
  },

Warning: anonymous function does not always return a value
Source File: chrome://editor/content/editorInlineSpellCheck.js
Line: 176, Column: 2
Source Code:
  }


}}
All these return values are unused and can be removed. Taking.
Assignee: mscott → mnyromyr
Status: NEW → ASSIGNED
Attachment #186968 - Flags: superreview?(dmose)
Attachment #186968 - Flags: review?(sfraser_bugs)
Attachment #186968 - Flags: review?(sfraser_bugs) → review+
Comment on attachment 186968 [details] [diff] [review]
trivially remove all unused return values
[Checked in: Comment 4]

sr=dmose
Attachment #186968 - Flags: superreview?(dmose) → superreview+
Comment on attachment 186968 [details] [diff] [review]
trivially remove all unused return values
[Checked in: Comment 4]

trivial strict warning removal
Attachment #186968 - Flags: approval1.8b3?
Attachment #186968 - Flags: approval-aviary1.1a2?
Attachment #186968 - Flags: approval1.8b3?
Attachment #186968 - Flags: approval1.8b3+
Attachment #186968 - Flags: approval-aviary1.1a2?
Attachment #186968 - Flags: approval-aviary1.1a2+
Checking in editorInlineSpellCheck.js;
new revision: 1.2; previous revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #186968 - Attachment description: trivially remove all unused return values → trivially remove all unused return values [Checked in: Comment 4]
Attachment #186968 - Attachment is obsolete: true
OS: Windows 98 → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8beta3
Comment on attachment 186968 [details] [diff] [review]
trivially remove all unused return values
[Checked in: Comment 4]

Serge, please *stop* marking patches as obsolete if they never were that. Just
because they're checked in doesn't mean they're obsolete...
Attachment #186968 - Attachment is obsolete: false
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: