295223 - Bookmark menu collapses when hovering folder in level 1, quickly marking another folder in level 1, and then hovering folder in level 2 (subfolder of first folder).

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Michael Kristensen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050521 Firefox/1.0+

Consider the following bookmark folder structure:

Folder 1
 - Random bookmark
 - Folder 2
   - Random bookmarks
   - Random bookmarks
Folder 3

If you hover folder 1, then quickly move over folder 3, whiout folder 3
expanding and then again quickly over folder 2.. Then when folder 2 should
expand, the bookmark menu collapses instead. It's kinda hard to explain, but
please ask, if there's something you don't understand.

Reproducible: Always

Steps to Reproduce:
1. Use the suggested folder structure (example should be attached as
bookmark.html ...)
2. Hover the folder 1, so that it expands.
3. Quickly move the folder over folder 3, whitout making it expand, then quickly
4. Hover folder 2, whitout moving over any bookmarks in folder 1. Wait until
folder 2 should expand.

Actual Results:  
Bookmark menu collapses

Expected Results:  
Folder 2 should have expanded.

I have checked that the bug exists in the release version of Firefox 1.0.4 - and
it does.

Comment 1

[Michael Kristensen]

Attachment: Example of bookmarks.html, where the problem exists

Comment 2

[Gabriel Chadwick]

I confirm this with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050523 Firefox/1.0+ and 1.0.4 .

Comment 3

[:Gavin Sharp [email: [e-mail]]]

[e-mail]:
Please don't confirm bugs unless you can identify the correct component in which
they belong.

Related: bug 67955.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

taking.

I will create the patch.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.0

Currently, when timer notify, we judge the opened menu is active or inactive.
But the way is not good. In the way, if most descendant menu item is active,
the menu is active. If not so, inactive. But when the sub-menu opened, the most
descendant menu is not inactive. But for user, the sub-menu is active.

Therefore, I changed the way, we should not judge when timer notify. We should
cancel the timer when descendant menu item is activated.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 192676 [details] [diff] [review]
Patch rv1.0

>--- layout/xul/base/src/nsIMenuParent.h	18 Apr 2004 14:30:36 -0000	1.24
>+++ layout/xul/base/src/nsIMenuParent.h	14 Aug 2005 16:12:20 -0000
>@@ -35,19 +35,19 @@
>  * the terms of any one of the MPL, the GPL or the LGPL.
>  *
>  * ***** END LICENSE BLOCK ***** */
> 
> #ifndef nsIMenuParent_h___
> #define nsIMenuParent_h___
> 
> 
>-// {D407BF61-3EFA-11d3-97FA-00400553EEF0}
>+// {0D1F2281-A530-419c-AE2C-21672590A9EC}
> #define NS_IMENUPARENT_IID \
>-{ 0xd407bf61, 0x3efa, 0x11d3, { 0x97, 0xfa, 0x0, 0x40, 0x5, 0x53, 0xee, 0xf0 } }
>+{ 0xd1f2281, 0xa530, 0x419c, { 0xae, 0x2c, 0x21, 0x67, 0x25, 0x90, 0xa9, 0xec } }

Just one minor thing, for consistency, leave a leading 0 on the first struct
member.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

checked-in.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: checked-in patch.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

now we can reproduce this bug again. see bug 387142.
# don't reopen this bug.