Closed Bug 295232 Opened 19 years ago Closed 19 years ago

Hardcoded accesskey for "<!ENTITY reportForm.problem_type.title"

Categories

(Other Applications Graveyard :: Reporter, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: unghost, Assigned: raccettura)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b2) Gecko/20050521 Firefox/1.0+ (BlueFyre)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b2) Gecko/20050521 Firefox/1.0+ (BlueFyre)

While I was translating reporter, I've noticed that accesskey for
"reportForm.problem_type.title" is hardcoded and can not be translated.
See
http://lxr.mozilla.org/mozilla/source/extensions/reporter/resources/content/reporter/reportWizard.xul#89

As you can see accesskey "T" for "Problem type" is hardcoded and can not be
translated.

Reproducible: Always

Actual Results:  
accesskey "T" for "Problem type" is hardcoded

Expected Results:  
accesskey "T" for "Problem type" can be localized
Screenshot showing hardcoded accesskey
Yes, your right, and while were at it, I should look at adding acess key's for
all fields.

I'll tackle this later in the day.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch PatchSplinter Review
Addes access key's to fields that can be localized.
Attachment #184351 - Flags: review?(mconnor)
Comment on attachment 184351 [details] [diff] [review]
Patch

r=me, minus the extra line after reportForm.behind_login.accesskey
Attachment #184351 - Flags: review?(mconnor) → review+
Comment on attachment 184351 [details] [diff] [review]
Patch

a=asa
Attachment #184351 - Flags: approval-aviary1.1a1+
Checking in extensions/reporter/locales/en-US/chrome/reportWizard.dtd;
/cvsroot/mozilla/extensions/reporter/locales/en-US/chrome/reportWizard.dtd,v 
<--  reportWizard.dtd
new revision: 1.8; previous revision: 1.7
done
Checking in extensions/reporter/resources/content/reporter/reportWizard.xul;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.xul,v
 <--  reportWizard.xul
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: