295232 - Hardcoded accesskey for "<!ENTITY reportForm.problem_type.title"

Status: RESOLVED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Alexander L. Slovesnik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b2) Gecko/20050521 Firefox/1.0+ (BlueFyre)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.8b2) Gecko/20050521 Firefox/1.0+ (BlueFyre)

While I was translating reporter, I've noticed that accesskey for
"reportForm.problem_type.title" is hardcoded and can not be translated.
See
http://lxr.mozilla.org/mozilla/source/extensions/reporter/resources/content/reporter/reportWizard.xul#89

As you can see accesskey "T" for "Problem type" is hardcoded and can not be
translated.

Reproducible: Always

Actual Results:  
accesskey "T" for "Problem type" is hardcoded

Expected Results:  
accesskey "T" for "Problem type" can be localized

Comment 1

[Alexander L. Slovesnik]

Attachment: Screenshot (russian localization of reporter)

Screenshot showing hardcoded accesskey

Comment 2

[Robert Accettura [:raccettura]]

Yes, your right, and while were at it, I should look at adding acess key's for
all fields.

I'll tackle this later in the day.

Comment 3

[Robert Accettura [:raccettura]]

Attachment: Patch

Addes access key's to fields that can be localized.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 184351 [details] [diff] [review]
Patch

r=me, minus the extra line after reportForm.behind_login.accesskey

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 184351 [details] [diff] [review]
Patch

a=asa

Comment 6

[Robert Accettura [:raccettura]]

Checking in extensions/reporter/locales/en-US/chrome/reportWizard.dtd;
/cvsroot/mozilla/extensions/reporter/locales/en-US/chrome/reportWizard.dtd,v 
<--  reportWizard.dtd
new revision: 1.8; previous revision: 1.7
done
Checking in extensions/reporter/resources/content/reporter/reportWizard.xul;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.xul,v
 <--  reportWizard.xul
new revision: 1.8; previous revision: 1.7
done