295236 - Leak in TableBackgroundPainter::PaintTable

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Ferdinand]

Found through valgrind: cgData isn't always deleted.

==8894== 3552 bytes in 111 blocks are definitely lost in loss record 292 of 323
==8894==    at 0x1B905430: operator new(unsigned) (vg_replace_malloc.c:132)
==8894==    by 0x1DB0E414: TableBackgroundPainter::PaintTable(nsTableFrame*,
nsMargin*) (nsTablePainter.cpp:395)
==8894==    by 0x1DAF0B1E: nsTableFrame::Paint(nsPresContext*,
nsIRenderingContext&, nsRect const&, nsFramePaintLayer, unsigned)
(nsTableFrame.cpp:1390)
==8894==    by 0x1D97826F: nsContainerFrame::PaintChild(nsPresContext*,
nsIRenderingContext&, nsRect const&, nsIFrame*, nsFramePaintLayer, unsigned)
(nsContainerFrame.cpp:282)
==8894==    by 0x1DAFD5AC: nsTableOuterFrame::Paint(nsPresContext*,
nsIRenderingContext&, nsRect const&, nsFramePaintLayer, unsigned)
(nsTableOuterFrame.cpp:334)
==8894==    by 0x1D97826F: nsContainerFrame::PaintChild(nsPresContext*,
nsIRenderingContext&, nsRect const&, nsIFrame*, nsFramePaintLayer, unsigned)
(nsContainerFrame.cpp:282)
==8894==    by 0x1D957B54: nsBlockFrame::PaintChild(nsPresContext*,
nsIRenderingContext&, nsRect const&, nsIFrame*, nsFramePaintLayer, unsigned)
(nsBlockFrame.h:286)
==8894==    by 0x1D963B97: PaintLine(nsRect const&, nsRect const&,
nsLineList_iterator&, int, int&, nsPresContext*, nsIRenderingContext&,
nsFramePaintLayer, nsBlockFrame*) (nsBlockFrame.cpp:6244)

Comment 1

[Ferdinand]

Attachment: patch

Comment 2

[Ferdinand]

Forget that, just noticed this patch isn't right.

Comment 3

[Bernd]

fantasai: don't we create cgdata on every paint of a table without clearing the
previously created?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Possibly better patch

Ferdinand, could you give this a spin in valgrind?

Comment 5

[Ferdinand]

Tried it on tweakers.net (which is where it showed up before).
There are no leaks in nsTablePainter anymore.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184329 [details] [diff] [review]
Possibly better patch

Comment 3 is not a problem because we never call PaintTable() more than once on
an nsTablePainter object.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184329 [details] [diff] [review]
Possibly better patch

jst, mind doing the sr? dbaron and roc are both away right now....

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 184329 [details] [diff] [review]
Possibly better patch

sr=dveditz

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184329 [details] [diff] [review]
Possibly better patch

Requesting approval -- this is a pretty simple leak fix.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Fixed.