Closed
Bug 295279
Opened 19 years ago
Closed 19 years ago
provide origin charset of original URI to error page
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: chpe)
Details
Attachments
(1 file, 1 obsolete file)
3.08 KB,
patch
|
chpe
:
review+
bzbarsky
:
superreview+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
I want to provide my own error page implementation instead of using the mozilla ones. The original URI is provided to the error page in the query string, but not the origin charset of the original URI. The origin charset is needed to unescape the address. The origin charset could simply be provided in the query string too.
Assignee | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Attachment #184402 -
Flags: superreview?(bzbarsky)
Attachment #184402 -
Flags: review+
Comment 2•19 years ago
|
||
Comment on attachment 184402 [details] [diff] [review] add charset parameter to error page URL This leaks; escapedCharset is never freed.
Attachment #184402 -
Flags: superreview?(bzbarsky) → superreview-
Assignee | ||
Comment 3•19 years ago
|
||
Free the escaped charset after use. (Transferring biesi's r+)
Attachment #184402 -
Attachment is obsolete: true
Attachment #184414 -
Flags: superreview?(bzbarsky)
Attachment #184414 -
Flags: review+
Updated•19 years ago
|
Attachment #184414 -
Flags: superreview?(bzbarsky) → superreview+
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 184414 [details] [diff] [review] add charset parameter to error page URL This is a simple addition for embedders who want to override the error pages. There's no risk, since error pages are not enabled by default.
Attachment #184414 -
Flags: approval1.8b3?
Comment on attachment 184414 [details] [diff] [review] add charset parameter to error page URL I thought we were getting rid of this query-string passing, myself, but that doesn't affect the merits of this when-in-rome patch. a=shaver
Attachment #184414 -
Flags: approval1.8b3? → approval1.8b3+
Updated•19 years ago
|
Assignee: cbiesinger → chpe
OS: Linux → All
Hardware: PC → All
Comment 6•19 years ago
|
||
Checking in docshell/base/nsDocShell.cpp; /cvsroot/mozilla/docshell/base/nsDocShell.cpp,v <-- nsDocShell.cpp new revision: 1.684; previous revision: 1.683 done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•