295279 - provide origin charset of original URI to error page

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

I want to provide my own error page implementation instead of using the mozilla
ones. The original URI is provided to the error page in the query string, but
not the origin charset of the original URI. The origin charset is needed to
unescape the address.

The origin charset could simply be provided in the query string too.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: add charset parameter to error page URL

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 184402 [details] [diff] [review]
add charset parameter to error page URL

This leaks; escapedCharset is never freed.

Comment 3

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: add charset parameter to error page URL

Free the escaped charset after use.

(Transferring biesi's r+)

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 184414 [details] [diff] [review]
add charset parameter to error page URL

This is a simple addition for embedders who want to override the error pages.
There's no risk, since error pages are not enabled by default.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 184414 [details] [diff] [review]
add charset parameter to error page URL

I thought we were getting rid of this query-string passing, myself, but that
doesn't affect the merits of this when-in-rome patch. a=shaver

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in docshell/base/nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.684; previous revision: 1.683
done