295306 - Firefox is unusable in solaris x86 using Sun SOS10 compiler.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Leon Sha]

See also bug 268524.
Firefox can start up, but you can not type anything in url bar.
This bug is very similar to bug 268524.
But I don't know why there is no problem with mozilla.

Comment 1

[Leon Sha]

But this time the problem is here:
mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_x86_solaris.cpp
I try to use the same method of bug 295306.
I write a inline template file, and compile it with 
xptcstubs_x86_solaris.cpp to assemble file. Then create a new assemble
file. But I met a problem. After compile the symble of 
STUB_ENTRY(0...9) is not confirmed with symble of STUB_ENTRY(10...99).
For example the symble of STUB_ENTRY(3) is 
__1cOnsXPTCStubBaseFStub36M_I_, the symble of STUB_ENTRY(33) is  
                   ^this is F
__1cOnsXPTCStubBaseGStub36M_I_,
                   ^this is G

I'll attach a patch of this bug. Although it is ungly, it do work.

Comment 2

[Leon Sha]

Attachment: Patch

Comment 3

[Darin Fisher]

Comment on attachment 184397 [details] [diff] [review]
Patch

Requesting approval on behalf of Leon.

Comment 4

[Leon Sha]

Checking in Makefile.in;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/Makefile.in,v  <--  Makefile.in
new revision: 1.80; previous revision: 1.79
done
RCS file:
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_asm_x86_solaris_SUNW.s,v
done
Checking in xptcstubs_asm_x86_solaris_SUNW.s;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_asm_x86_solaris_SUNW.s,v
 <--  xptcstubs_asm_x86_solaris_SUNW.s
initial revision: 1.1
done
Checking in xptcstubs_x86_solaris.cpp;
/cvsroot/mozilla/xpcom/reflect/xptcall/src/md/unix/xptcstubs_x86_solaris.cpp,v
<--  xptcstubs_x86_solaris.cpp
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Boying Lu]

Attachment: To build mozilla in a sparated directory.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

is there really no better way than this? the source dir should not be written to.

Comment 7

[Ginn Chen]

second patch checked in

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 202455 [details] [diff] [review]
To build mozilla in a sparated directory.

This is really backwards; the two lines that you changed were right before, and the line in the middle needs to do something different so that it works with what was there before.

Comment 9

[Ginn Chen]

Attachment: address dbaron's comment

Comment 10

[Ginn Chen]

third patch checked in

Comment 11

[Justin Dolske [:Dolske]]

*** Bug 305748 has been marked as a duplicate of this bug. ***

Comment 12

[Justin Dolske [:Dolske]]

Attachment: Cleaned up patch

This is a cleaned up version from comment #9 / attachment 206071 [details] [diff] [review] (since there's no mistaken "patch #2" to fix on the 1.8 branch).

I ran across the original problem when compiling FF2 on Solaris, and this fixed it.

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 245710 [details] [diff] [review]
Cleaned up patch

approved for 1.8 branch, a=dveditz for drivers

Comment 14

[Ginn Chen]

already checked in on 1.8 branch for Firefox 2.0.0.1