295481 - WINCE fix up

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect)

Description

[Doug Turner (:dougt)]

This patch fixes:

dropdown menus (such as in a html select).  targeting is still broken.
removes ifdef's around FlashWindow -- it is now implemented in the wince shunt.dll
enables the MouseTrailer class on windows ce.
moved DealWithPopups out of shared code and under a WINCE ifdef.

Comment 1

[Doug Turner (:dougt)]

Attachment: gfx/widget Patch v.1

Comment 2

[Ere Maijala (slow)]

Comment on attachment 184508 [details] [diff] [review]
gfx/widget Patch v.1

Could you split the beginning of nsRenderingContextWin ::
nsRenderingContextWin() into two parts so that the WINCE part just sets
gIsWIN95 and gBidiInfo in the beginning instead of ifndef+ifdef?

+#ifndef WINCE	// Windows CE is created when nsToolkit
+		// starts up, not when the dll is loaded.

It would please my eye better if the comment was above the ifndef.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 4

[Ere Maijala (slow)]

Comment on attachment 184932 [details] [diff] [review]
patch v.2

r=emaijala

Comment 5

[rbs]

Comment on attachment 184932 [details] [diff] [review]
patch v.2

sr=rbs

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 184932 [details] [diff] [review]
patch v.2

WinCE stuff.  a=1.8b3 please

Comment 7

[Doug Turner (:dougt)]

fix checed in. thx