Closed Bug 295481 Opened 19 years ago Closed 19 years ago

WINCE fix up

Categories

(Core Graveyard :: GFX: Win32, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file, 1 obsolete file)

This patch fixes:

dropdown menus (such as in a html select).  targeting is still broken.
removes ifdef's around FlashWindow -- it is now implemented in the wince shunt.dll
enables the MouseTrailer class on windows ce.
moved DealWithPopups out of shared code and under a WINCE ifdef.
Attached patch gfx/widget Patch v.1 (obsolete) — Splinter Review
Attachment #184508 - Flags: superreview?
Attachment #184508 - Flags: review?(emaijala)
Comment on attachment 184508 [details] [diff] [review]
gfx/widget Patch v.1

Could you split the beginning of nsRenderingContextWin ::
nsRenderingContextWin() into two parts so that the WINCE part just sets
gIsWIN95 and gBidiInfo in the beginning instead of ifndef+ifdef?

+#ifndef WINCE	// Windows CE is created when nsToolkit
+		// starts up, not when the dll is loaded.

It would please my eye better if the comment was above the ifndef.
Attachment #184508 - Flags: superreview?
Attachment #184508 - Flags: review?(emaijala)
Attachment #184508 - Flags: review-
Attached patch patch v.2Splinter Review
Attachment #184508 - Attachment is obsolete: true
Attachment #184932 - Flags: review?(emaijala)
Comment on attachment 184932 [details] [diff] [review]
patch v.2

r=emaijala
Attachment #184932 - Flags: review?(emaijala) → review+
Attachment #184932 - Flags: superreview?(rbs)
Comment on attachment 184932 [details] [diff] [review]
patch v.2

sr=rbs
Attachment #184932 - Flags: superreview?(rbs) → superreview+
Comment on attachment 184932 [details] [diff] [review]
patch v.2

WinCE stuff.  a=1.8b3 please
Attachment #184932 - Flags: approval1.8b3?
Attachment #184932 - Flags: approval1.8b3? → approval1.8b3+
fix checed in. thx
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: