Closed
Bug 295481
Opened 19 years ago
Closed 19 years ago
WINCE fix up
Categories
(Core Graveyard :: GFX: Win32, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file, 1 obsolete file)
32.71 KB,
patch
|
emaijala+moz
:
review+
rbs
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
This patch fixes: dropdown menus (such as in a html select). targeting is still broken. removes ifdef's around FlashWindow -- it is now implemented in the wince shunt.dll enables the MouseTrailer class on windows ce. moved DealWithPopups out of shared code and under a WINCE ifdef.
Assignee | ||
Comment 1•19 years ago
|
||
Assignee | ||
Updated•19 years ago
|
Attachment #184508 -
Flags: superreview?
Attachment #184508 -
Flags: review?(emaijala)
Comment 2•19 years ago
|
||
Comment on attachment 184508 [details] [diff] [review] gfx/widget Patch v.1 Could you split the beginning of nsRenderingContextWin :: nsRenderingContextWin() into two parts so that the WINCE part just sets gIsWIN95 and gBidiInfo in the beginning instead of ifndef+ifdef? +#ifndef WINCE // Windows CE is created when nsToolkit + // starts up, not when the dll is loaded. It would please my eye better if the comment was above the ifndef.
Attachment #184508 -
Flags: superreview?
Attachment #184508 -
Flags: review?(emaijala)
Attachment #184508 -
Flags: review-
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #184508 -
Attachment is obsolete: true
Assignee | ||
Updated•19 years ago
|
Attachment #184932 -
Flags: review?(emaijala)
Comment 4•19 years ago
|
||
Comment on attachment 184932 [details] [diff] [review] patch v.2 r=emaijala
Attachment #184932 -
Flags: review?(emaijala) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #184932 -
Flags: superreview?(rbs)
Comment on attachment 184932 [details] [diff] [review] patch v.2 sr=rbs
Attachment #184932 -
Flags: superreview?(rbs) → superreview+
Assignee | ||
Comment 6•19 years ago
|
||
Comment on attachment 184932 [details] [diff] [review] patch v.2 WinCE stuff. a=1.8b3 please
Attachment #184932 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #184932 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 7•19 years ago
|
||
fix checed in. thx
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•