Closed
Bug 295494
Opened 20 years ago
Closed 20 years ago
Add support for extension chrome.manifest to make-jars
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta3
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
12.84 KB,
patch
|
darin.moz
:
review+
shaver
:
approval-aviary1.1a2+
|
Details | Diff | Splinter Review |
Right now, make-jars.pl generates $(FINAL_TARGET)/chrome/<jarname>.manifest,
which is correct if you are making "builtin" chrome. However, it is not correct
if you are making an extension using the XPI_NAME goop: in that case, we should
generate $(FINAL_TARGET)/chrome.manifest.
|
Assignee | |
Comment 1•20 years ago
|
||
This patch allows me to build DOMI as a real extension and ship it to
dist/bin/extensions/<GUID> after building.
Attachment #184614 -
Flags: review?(darin)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 184614 [details] [diff] [review]
Add -e flag to make-jars which builds chrome.manifest instead of <jarfile>.manifest
looks fine to me, r=darin
Attachment #184614 -
Flags: review?(darin) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #184614 -
Flags: approval-aviary1.1a2?
|
||
Comment 3•20 years ago
|
||
Comment on attachment 184614 [details] [diff] [review]
Add -e flag to make-jars which builds chrome.manifest instead of <jarfile>.manifest
a=shaver.
Attachment #184614 -
Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixed on trunk, with a change to calendar/lightning/Makefile.in to use DIST_FILES
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta3
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•