Closed Bug 295947 Opened 19 years ago Closed 19 years ago

[FIXr]list-style-position: inside horked on document mutations

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta4

People

(Reporter: glazou, Assigned: bzbarsky)

References

(
URL
)

Details

Attachments

(2 files)

Testcase showing this is not just an editor issue
570 bytes, text/html
Details
Simple fix...
2.31 KB, patch
dbaron
: review+
dbaron
: superreview+
benjamin
: approval1.8b4+
Details | Diff | Splinter Review 
1. launch Firefox
2. browse the attached URL
3. follow the explanations

Expected result: list item number before the text
Actual result: list item number after the text...

This bug was reported by an Nvu user.
Forgot to mention this is in FF1.0.4.
Version: Trunk → 1.0 Branch
Summary: list-style-position: inside horked in editor → list-style-position: inside horked on document mutations
Attached patch Simple fix... — — Splinter Review 

        Attachment #191200 -
        Flags: superreview?(dbaron)

        Attachment #191200 -
        Flags: review?(dbaron)

    
  
Assignee: nobody → bzbarsky
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Summary: list-style-position: inside horked on document mutations → [FIX]list-style-position: inside horked on document mutations
Target Milestone: --- → mozilla1.8beta4
Version: 1.0 Branch → Trunk

    
    

    
  
Comment on attachment 191200 [details] [diff] [review]
Simple fix...

r+sr=dbaron on the second half of the patch;  the first half is from another
bug that I've seen a good bit of bugmail for recently

        Attachment #191200 -
        Flags: superreview?(dbaron)

        Attachment #191200 -
        Flags: superreview+

        Attachment #191200 -
        Flags: review?(dbaron)

        Attachment #191200 -
        Flags: review+

    
    

    
  
Comment on attachment 191200 [details] [diff] [review]
Simple fix...

Er, yes.  The first half should not have been here, and I'll make sure not to
land it.

Requesting 1.8b4 approval.  This is a very safe fix to our handling of DOM
mutations of blocks with inside bullets.

        Attachment #191200 -
        Flags: approval1.8b4?

    
  
Summary: [FIX]list-style-position: inside horked on document mutations → [FIXr]list-style-position: inside horked on document mutations

    
    

    
  
Comment on attachment 191200 [details] [diff] [review]
Simple fix...

a=bsmedberg for the second half ;-)

        Attachment #191200 -
        Flags: approval1.8b4? → approval1.8b4+

    
    

    
  
Fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: