Closed Bug 296136 Opened 19 years ago Closed 19 years ago

Add necessary lines to os2charset.properties

Categories

(Core :: Internationalization, defect)

x86
OS/2
defect
Not set
minor

Tracking

()

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

Attachments

(1 file)

There was a thread in the n.p.m.os2 newsgroup in April titled "Mozilla and
codepage 921" about non-displaying characters on Baltic (iso-8859-13) webpages
if the system was set up with codepage 921. The problem was obviously solved by
adding the line
   os2.921=ISO-8859-13
to intl/uconv/src/os2charset.properties. I guess we need to get this in the
tree. Are any other lines missing? E.g. why is there no line for ISO-8859-2? Is
this OS/2 file on to override good defaults for other platforms?
This file is basically serving one purpose - map system charsets to Mozilla
charsets. Each platform has this file.

So what should be in this file is charsets that people use as their system code
page and their Mozilla equivalents.
Attached patch Add codepage 921Splinter Review
OK, I found out that the assignments in this file are already good for e.g.
Polish codepage (cp852) and nobody yet complained about anything else than
cp921, so it's probably enough to add this for now.
Attachment #190559 - Flags: superreview?(mozilla)
Attachment #190559 - Flags: review?(mozilla)
Comment on attachment 190559 [details] [diff] [review]
Add codepage 921

r/sr/a=mkaply (OS/2 only)
Attachment #190559 - Flags: superreview?(mozilla)
Attachment #190559 - Flags: superreview+
Attachment #190559 - Flags: review?(mozilla)
Attachment #190559 - Flags: review+
Attachment #190559 - Flags: approval1.8b4+
Did this ever get checked in?
No, I can see it in CVS still unpatched.
Assignee: mozilla → mozilla
Thanks bz
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: