296212 - For pages that are just name=value&name2=value2& the last ampersand is dropped.

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Matthew Cheale]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511

Look at the URL in Mozilla and IE.  You can see that IE renders the final
ampersand whereas Mozilla looses it.  I know it's not much of a HTML page but I
was writing a page that outputted data in this format but couldn't see a error
in the loop because of the missing &.  Not a biggy but I'm unaware of any
consequences this may have.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Josh Birnbaum]

Ampersands cannot appear by themselves in HTML, they start a character
reference.  If you want to encode an ampersand in HTML, you need to use |&|
instead of just |&|

As for this bug, it's technically invalid, but leaving open in case the parser
folks want to do anything about this edge case.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, this is an edge case we should handle properly -- especially considering
the final ampersand doesn't show up in view source.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

This simply consumes the last & in the file as text. The Peek() is checking the
2nd character after the current one.

Note the migration away from mIsFinalChunk because it is insufficient in the
face of document.write(), where we can have mIsFinalChunk = PR_TRUE, but
aScanner.IsIncremental() = PR_TRUE.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 185039 [details] [diff] [review]
patch v1

r=jst

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 185039 [details] [diff] [review]
patch v1

This safe patch makes the parser not lose data, and makes view source not lie
so much.

Comment 6

[chris hofmann]

Comment on attachment 185039 [details] [diff] [review]
patch v1

a=chofmann

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

The final ampersand is indeed rendered when viewing the following URL
http://www.sayten.34sp.com/moztests/dropping_ampersands.html in today's
2005-06-03-06 Windows XP Seamonkey trunk build.

Output is as follows:

db_pass=tpa&db_server=beastie4&db_user=tpa&

(The final ampersand shows up in view source as well in bolded orange.)

Verified FIXED

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: testcase

Attaching the testcase for future reference.