296284 - <blockquote type=cite> can potentially confuse the plaintext serializer

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

In the patch for bug 144998, I noticed that there was a case where having:
<blockquote type=cite>...</blockquote>
<p>some stuff</p>
<pre>more stuff</pre>

could cause a newline to get removed between the <pre> and the <p>. I suspect
there is a fairly simple fix (which I will try in a short while).

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

The example in comment 0 doesn't show this bug. I'm trying to find one that does.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

The problem was that mHasWrittenCiteBlockquote was extending its effect even
after it wasn't true, so we were munching up the newlines.

There didn't seem to be a good place to put these tests (they aren't mailquote
tests, per se) so I made a new file for testing random HTML (misc. html).

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 185088 [details] [diff] [review]
patch v1

sr=jst

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 185088 [details] [diff] [review]
patch v1

This is a safe fix that fixes a small regression in the plaintext serializer.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked in.

Comment 6

[Jef Driesen]

I discovered a very similar problem. Take a look at
http://forums.mozillazine.org/viewtopic.php?p=1583430 for a description of the
problem.