296309 - [FIXr]Add an IntrinsicState() method to nsIContent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

I was planning to do this in bug 11011, but Allan needs this for XForms now-ish,
and this part of the patch stands on its own...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

This creates the method and implements :checked in terms of it.  I talked to
Allan, and it looks like we'd need on the order of 20-25 bits in the event
state to do all of CSS3 UI plus my borken-image/object changes (21 as things
stand, but I may want another image state or two).  So there's no need to use
anything other than a simple bitfield for state yet.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same but with the IID fixed

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 185103 [details] [diff] [review]
Same but with the IID fixed

Not sure if you really want the mType check in the nsHTMLInputElement changes;
it wasn't there before; perhaps an assertion instead?

I'm glad to see one use of NS_EVENT_STATE_UNSPECIFIED go; named constants for
the zero bitfield are confusing; getting rid of the other two would be nice.

r+sr=dbaron

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Not sure if you really want the mType check in the nsHTMLInputElement changes;

I do.  Before, we failed the following testcase:

  data:text/html,<style>:checked { background: red }</style><input checked>

That is, we painted a red background on that textfield.  That seems wrong to me.

I can replace the other two users of NS_EVENT_STATE_UNSPECIFIED with 0 and
remove the define if you want.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 185103 [details] [diff] [review]
Same but with the IID fixed

Requesting 1.8b3 approval.  This is some very safe arch work that xforms needs
badly and that lays the groundwork for other things we want to get done.

Comment 6

[chris hofmann]

Comment on attachment 185103 [details] [diff] [review]
Same but with the IID fixed

a=chofmann

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to review comments

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed for 1.8b3.  This might have even helped Tp a tad; hard to tell...