296339 - No response when I am inputting use the MSPinYin(Chinese) input method

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[fengxs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4

When I am compose a mail(in ThunderBird) or submit some messages(in FireFox), I
use the MSPinYin 2003 input
method(http://download.microsoft.com/download/b/6/5/b6554006-de1b-4160-9aee-62accd789373/MSPY.msi),
but sometimes the cursor can not move use the keyboard. I must change the
InputMethod to English, then turn back to MSPinYin 2003 again, everything will
be fine, but after inputted some words, the bug will come back. The bug not only
in MSPinYin 2003, but MSPinYin 3.0 and another MSPinYin InputMethod versions.

Reproducible: Couldn't Reproduce

Steps to Reproduce:
1.Open ThunderBird to compose a mail
2.Change to MSPinYin input method
3.Input some Chinese words, move the cursor use the keyboard
4.If the cursor can be moved, do Step 3 again

Actual Results:  
Can not Move the Cursor use the KeyBoard.

Expected Results:  
Can move the Cursor use the KeyBoard every time.

The bug not only in MSPinYin 2003, but MSPinYin 3.0 and another MSPinYin
InputMethod versions.

Comment 1

[Andrew Schultz]

please try a trunk build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/deerpark/alpha1/

==> intl

Comment 2

[fengxs]

Thank you so very much.

I have test the trunk build(Deer Park Alpha 1), the bug is still exist...

but I found a easy method to reproduce it:
1.Open ThunderBird to compose a mail
2.Change to MSPinYin input method
3.Just input a Chinese full stop("。") word, move the cursor use the keyboard,
you will can not move it.

(In reply to comment #1)
> please try a trunk build:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/releases/deerpark/alpha1/
> 
> ==> intl

Comment 3

[Jungshik Shin]

Masayuki, can you take a look? 

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot reproduce with MSPinYin 2.0 on Win2k.

Comment 5

[fengxs]

Sorry for this my mistake...

The bug is exist in:
1. MSPinYin 2003
2. Windows 2000 Professional
3. Windows XP Professional

Please download MSPinYin 2003 from this
link:http://download.microsoft.com/download/b/6/5/b6554006-de1b-4160-9aee-62accd789373/MSPY.msi

thank for your in time and excellent reply.
bagggio.

(In reply to comment #4)
> I cannot reproduce with MSPinYin 2.0 on Win2k.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

O.K. I can reproduce it.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

It fixes this bug.
And the bottom of this patch's fixes the debug code's another bug. That blocks
Hangul IME test for this patch.

Comment 8

[timeless]

Comment on attachment 185849 [details] [diff] [review]
Patch rv1.0

>Index: widget/src/windows/nsWindow.cpp
>@@ -6619,16 +6623,34 @@ BOOL nsWindow::OnIMEComposition(LPARAM a
>+    if (sIMECompUnicode->Length() == 0 &&
use sIMECompUnicode->IsEmpty()

>+      // string is null(it indicates the composition transaction ended),
			^^^ space please

Comment 9

[rbs]

Comment on attachment 185849 [details] [diff] [review]
Patch rv1.0

sr=rbs

nitpicking:
+    if (sIMECompUnicode->Length() == 0 &&
+	 !startCompositionMessageHasBeenSent) {

to

+    if (sIMECompUnicode->IsEmpty() &&
+	 !startCompositionMessageHasBeenSent)

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.1

Thank you, timeless and rbs!

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.