Closed
      
        Bug 296628
      
      
        Opened 20 years ago
          Closed 20 years ago
      
        
    
  
hitting tab in print preview crashes [@ IsRootFrame]  
    Categories
(Core :: Layout, defect)
Tracking
()
        VERIFIED
        FIXED
        
    
  
People
(Reporter: ajschult784, Assigned: roc)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(2 files)
| 4.68 KB,
          text/plain         | Details | |
| 1.02 KB,
          patch         | bzbarsky
:
              
              review+ bzbarsky
:
              
              superreview+ asa
:
              
              approval1.8b3+ | Details | Diff | Splinter Review | 
With linux suite trunk 2005060301, if I hit tab immediately after bringing up
print preview, it crashes.  This regressed between 6/1 and 6/2 builds and (based
on stack) is from bug 289250.
| Reporter | ||
| Comment 1•20 years ago
           | ||
|   | ||
| Comment 2•20 years ago
           | ||
Related/dupe of bug 296413?
|   | ||
| Updated•20 years ago
           | 
Flags: blocking1.8b3?
| Assignee | ||
| Comment 3•20 years ago
           | ||
Simple issue ... we die when traversal is already at the root. This brings this
call to IsRootFrame into consistency with the other calls.
        Attachment #186436 -
        Flags: superreview?(bzbarsky)
        Attachment #186436 -
        Flags: review?(bzbarsky)
|   | ||
| Updated•20 years ago
           | 
        Attachment #186436 -
        Flags: superreview?(bzbarsky)
        Attachment #186436 -
        Flags: superreview+
        Attachment #186436 -
        Flags: review?(bzbarsky)
        Attachment #186436 -
        Flags: review+
| Assignee | ||
| Comment 4•20 years ago
           | ||
Comment on attachment 186436 [details] [diff] [review]
fix
simple, no-risk crasher fix
        Attachment #186436 -
        Flags: approval1.8b3?
| Updated•20 years ago
           | 
        Attachment #186436 -
        Flags: approval1.8b3? → approval1.8b3+
| Assignee | ||
| Comment 5•20 years ago
           | ||
checked in
Status: NEW → RESOLVED
Closed: 20 years ago
Flags: blocking1.8b3?
Resolution: --- → FIXED
| Comment 6•20 years ago
           | ||
There is a crash that occurs on Windows trunk builds: bug 244128.
It happens when tab shifts focus.  Stack is here:
https://bugzilla.mozilla.org/attachment.cgi?id=186683
| Comment 7•20 years ago
           | ||
Verified FIXED with build 2005-08-06-06 on SeaMonkey trunk with Windows XP.
Status: RESOLVED → VERIFIED
| Updated•14 years ago
           | 
Crash Signature: [@ IsRootFrame]
          You need to log in
          before you can comment on or make changes to this bug.
        
Description
•