296657 - textContent outputs comment nodes

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect)

Description

[Jason Barnabe (np)]

DOM Core Level 3 says

"The string returned is made of the text content of this node depending on its
type, as defined below:

Node type:
ELEMENT_NODE, ATTRIBUTE_NODE, ENTITY_NODE, ENTITY_REFERENCE_NODE,
DOCUMENT_FRAGMENT_NODE

Content: concatenation of the textContent attribute value of every child node,
*excluding COMMENT_NODE* and PROCESSING_INSTRUCTION_NODE nodes. This is the
empty string if the node has no children."

We're not exluding comment nodes.

Comment 1

[Jason Barnabe (np)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Is this a regression from bug 285830?

Comment 3

[[e-mail]]

Oops :-[

bz, should I a) call IsContentTypeOf(eTEXT) and cast to nsITextContent, b) QI to
nsITextContent and call IsContentTypeOf(eTEXT) or c) something else?

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

b). Though do the IsContentOfType test first to avoid unneccesary QIs.

Comment 5

[Hixie (not reading bugmail)]

Remember that .textContent on a comment itself should return the text, just that
a parent of a comment should not include the comment. As described here:

   http://www.w3.org/TR/DOM-Level-3-Core/core.html#Node3-textContent

Comment 6

[Boris Zbarsky [:bzbarsky]]

What sicking said.

Comment 7

[[e-mail]]

Attachment: Belt and braces

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 185410 [details] [diff] [review]
Belt and braces

sr=jst

Comment 9

[[e-mail]]

Comment on attachment 185410 [details] [diff] [review]
Belt and braces

seeking approval for regression fix.

Comment 10

[[e-mail]]

Fix checked in.