297162 - Fix non-neutral endian code in mac gfx font code

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Mac, defect)

Description

[Josh Aas]

This fix was provided by Apple in a set of patches for building and running
Firefox on Intel-based Macs. We have some font code that assumes big endian, and
this patch fixes that.

Comment 1

[Josh Aas]

Attachment: Apple fix v1.0

Comment 2

[chris hofmann]

Comment on attachment 185751 [details] [diff] [review]
Apple fix v1.0

a=chofmann

Comment 3

[Josh Aas]

landed on trunk

Comment 4

[Simon Fraser [no longer active]]

I backed this out because it doesn't build pre-tiger; the byte-swap routines are
not available.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The functions at
http://lxr.mozilla.org/seamonkey/source/nsprpub/pr/include/prnetdb.h#477 could
be useful.

Comment 6

[Mark Mentovai]

Those routines should be available, but they're in a header that's apparently
not included by default on Jaguar or Panther.  (I didn't test Tiger either, but
I assume Apple did.)

Their patch will probably work as-is with #include <libkern/OSByteOrder.h>.

The PR_* macros are a more circuitous way to eventually wind up at the same
OSSwap*, which uses inline asm where necessary.

Comment 7

[Mark Mentovai]

The PR_* guys are functions, not macros - best to use OSSwap* directly.

Comment 8

[Mark Mentovai]

Forget that, bringing in libkern brings in parts of the kernel ABI.  We don't
need that pain in the butt.  Let's use CFSwapInt16BigToHost, which also gives us
inline asm swapping where needed.  Tested with SDK 10.2.7.  Will have it in
patch form later.

Comment 9

[Mark Mentovai]

Attachment: Use CFSwap* instead of OSSwap*

This is functionally identical but works on all supported build platforms.

Comment 10

[Josh Aas]

landed on trunk