Closed
Bug 297164
Opened 20 years ago
Closed 20 years ago
fix endian issues in asdecode
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
jaas
:
review+
sfraser_bugs
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
We are assuming big endian in asdecode, which isn't OK for Intel-based macs. A
patch was provided by Apple to fix the problem.
Attachment #185752 -
Flags: superreview?(sfraser_bugs)
Attachment #185752 -
Flags: review+
|
||
Updated•20 years ago
|
Attachment #185752 -
Flags: superreview?(sfraser_bugs) → superreview+
Attachment #185752 -
Flags: approval1.8b3?
|
||
Updated•20 years ago
|
Attachment #185752 -
Flags: approval1.8b3? → approval1.8b3+
Checked in to trunk.
Checking in asdecode.cpp;
/cvsroot/mozilla/config/asdecode.cpp,v <-- asdecode.cpp
new revision: 3.5; previous revision: 3.4
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment on attachment 185752 [details] [diff] [review]
Apple fix v1.0
>+ entry *swap = &entries[i];
>+ swap->id = OSSwapBigToHostInt32(swap->id);
>+ swap->offset = OSSwapBigToHostInt32(swap->offset);
>+ swap->length = OSSwapBigToHostInt32(swap->length);
>+
> entry& entry = entries[i];
No need for the |swap| variable; you can just use the existing |entry|
variable.
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•