297669 - Print 0 height/width IFRAME via Javascript print() causes endless print spooling.

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Ben Trafford]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414 Firefox/1.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.8) Gecko/20050511 Firefox/1.0.4


In the example given at http://www.prodigal.ca/PrintFrameBug/, we have an IFRAME
that's been set to minimal size -- no borders, no margins, no height, no width.
This has been set via http://www.prodigal.ca/PrintFrameBug/test.css, as well as
in the HTML markup, itself.

In the parent document, there is a Javascript function to set focus and print
the IFRAME. The function is enabled via an onClick event in an A tag. When
clicked, the print process spools endlessly and does nothing. I would expect
either a failure message (e.g. "You can't print an invisible IFRAME, dude!") or
a print-out of the IFRAME's content.

On Windows XP Professional SP2, print spooling will not cancel once this link is
clicked until Firefox is shutdown completely.

Reproducible: Always

Steps to Reproduce:
1. Open Firefox to http://www.prodigal.ca/PrintFrameBug/
2. Click on the link that says "Print this."


Actual Results:  

My printer (and I tried six of them, including Adobe's Acrobat printer) spooled
and spooled and spooled. It would not cancel printing until I shutdown Firefox
completely, at which point, it was possible to cancel the print job.

Expected Results:  
Either printed the IFRAME's contents, which consists of a plain sentence saying,
"Is this going to work? Sure hope so!" or given me an error of some sort.


The files used to create this example are available for download at:

http://www.prodigal.ca/PrintFrameBug/printframebug.zip

The error occurred whether the file was opened locally or accessed via a server.

Comment 1

[Ben Trafford]

Additional testing using an onLoad function in the BODY of the IFRAME to try the
print() also created the same bug. In addition, both solutions were tested via
"Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.7) Gecko/20050414
Firefox/1.0.3," with the same result.

Comment 2

[Martijn Wargers (dead)]

Could you test this with the nightly trunk build?
http://ftp.scarlet.be/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 3

[Ben Trafford]

Deer Park Alpha 1 has the exact same behavior as the other version. I select the
print link, the Printing dialog pops up and declaring that it is Preparing the
print; the printer in my taskbar appears, and when clicked, says it's
spooling...and then nothing.

Comment 4

[Martijn Wargers (dead)]

Attachment: patch

Well, removing those lines makes it work for me.
I have no idea if that's allowed, though. Those lines might have been put there
for a reason :-)
Robert might know this.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It was added here.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsDocumentViewer.cpp&rev2=1.244&rev1=1.243

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

 *  Check to see if the FrameSet Frame is Hidden
 *  if it is then don't let it be reflowed, printed, or shown

So that really shouldn't be interfering with anything.

Comment 7

[Ben Trafford]

Robert, I'm confused as to what you mean by "it shouldn't be interfering with
anything." Do you mean that the behavior I'm seeing is correct, or that you have
no idea why it would be causing the print spooling problem?

I'm guessing that the print process isn't taking into account the directive to
be unprintable, which is a wrong-headed directive, anyhow. I should be able to
print even non-visible areas of a frame.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #7)
> Robert, I'm confused as to what you mean by "it shouldn't be interfering with
> anything." Do you mean that the behavior I'm seeing is correct, or that you
> have no idea why it would be causing the print spooling problem?

The latter.

> I'm guessing that the print process isn't taking into account the directive to
> be unprintable, which is a wrong-headed directive, anyhow. I should be able to
> print even non-visible areas of a frame.

Yes, you probably should.

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 186842 [details] [diff] [review]
patch

Thanks for the link, Robert.
so basically I was disabling the whole CheckForHiddenFrameSetFrames function
here.
Maybe that whole function can be removed, without regressing bug 134769 now,
which it tried to fix.
(I saw your name on the bonsai blame, so I thought you might know this code)

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Feel free to try it, Martijn :-)

Comment 11

[Martijn Wargers (dead)]

Attachment: patch2

Ok, this seems to work without regressing bug 134769, on first sight.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 187157 [details] [diff] [review]
patch2

Yeah, that looks good. If this causes a regression we should fix the underlying
bug rather than doing this hack.

Comment 13

[chris hofmann]

Comment on attachment 187157 [details] [diff] [review]
patch2

a=chofmann

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 15

[Martijn Wargers (dead)]

Wow, that was fast. 
It'll not be likely that I can fix eventuel regressions. My c knowledge doesn't
go further than the ability to remove code.

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'll take care of it if necessary

Comment 17

[Place Holder]

*** Bug 203334 has been marked as a duplicate of this bug. ***