297792 - JavaScript strict warning in reportWizard.js

Status: VERIFIED FIXED

(Other Applications Graveyard :: Reporter, defect)

Description

[Romain BEZUT]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050614 Firefox/1.0+

When I go on "Report Broken Web Site" under the "Help" menu, I get the following
javascript strict warning :

Warning: function getBuildConfig does not always return a value
Source File: chrome://reporter/content/reportWizard.js
Line: 299, Column: 10
Source Code:
    return;

(If you want to see this warning, "Strict warnings" have to be enabled)

Reproducible: Always

Steps to Reproduce:
1. Go on "Help", then go on "Report Broken Web Site"
2. See in the JavaScript Console the warning above

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050614
Firefox/1.0+

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch

Robert, is it ok that we return an empty string when the build config is not
available?

Comment 3

[Robert Accettura [:raccettura]]

Comment on attachment 186402 [details] [diff] [review]
patch

Yea, go for it.

The server will likely bark in the unlikely sinareo, but I can tweak the server
to ignore it should that happen.

Comment 4

[Robert Accettura [:raccettura]]

Actually...

Lets make it return "Unknown".

With that change r=[e-mail]

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: patch v2

Take over r+ from comment 4.

Comment 6

[Robert Accettura [:raccettura]]

Checking in extensions/reporter/resources/content/reporter/reportWizard.js;
/cvsroot/mozilla/extensions/reporter/resources/content/reporter/reportWizard.js,v
 <--  reportWizard.js
new revision: 1.21; previous revision: 1.20
done

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

v