29820 - Remove "Changed" from email subject line

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Richard Zach]

Can you remove the "Changed -" from the subject line, so that it is of the form
"[Bug xxxx] Summary".  Would make it easier to recognize bugs from the subject
line, which is otherwise truncated in the thread display.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Chris Yeh]

good suggestion, maybe for 2.12

Comment 3

[Zach Lipton [:zach]]

Attachment: patch to fix...

Comment 4

[Zach Lipton [:zach]]

Attachment: slightly less hacky patch to fix...

Comment 5

[Chris Yeh]

checked into trunk with commentary

Comment 6

[Stephan Niemz]

*** Bug 48741 has been marked as a duplicate of this bug. ***

Comment 7

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 8

[Jacob Steenhagen]

Yeppers.

Comment 9

[Stephan Niemz]

Reopening.

The subject is now "[Bug nn]  - subject" which means still four excess characters
(space, space, dash, space).  Attaching a new patch.  Also, the description in
defparams.pl wasn't correct any more - this patch fixes this, too.

Please make sure that when bugzilla.mozilla.org updates to this patch that the
parameter "changedmail" is also reset to the new default.  Thanks!

Comment 10

[Stephan Niemz]

Attachment: new patch (diff -ubB)

Comment 11

[Stephan Niemz]

Attachment: new patch (diff -u, also removing spaces at line endings)

Comment 12

[Dave Miller [:justdave]]

r= [e-mail]

except:  I think the [Bug xxxx] should still be first before the %neworchanged% 
in the default.  I'd bet that a LOT of people probably have mail filters that 
look for the subject beginning with "[Bug ".

Comment 13

[Dave Miller [:justdave]]

Attachment: New patch

Comment 14

[Dave Miller [:justdave]]

Here's a new version of the patch, I swapped the order around again so that the 
"[Bug xxx]" is always first.  I also discovered that the previous patch posted 
here only patched the defparam for "changedmail" and only patched the 
substitution setup on the newemailtech (which uses "newchangedmail").  This patch 
also adds the change to defparams for "newchangedmail" and also the change to the 
substitution setup for oldemailtech.

Comment 15

[Jacob Steenhagen]

The only thing I don't like about this latest patch is that if you don't go in
and change your parameters to the new default, new bugs of a subject line like
follows:
[Bug 35] New:  - Reorginize the Hilite Intranet

OTOH, I really don't see a way around that.  Guess that's just another thing to
put in the 2.12 release notes (are those in the works?).

r= [e-mail]

Comment 16

[Stephan Niemz]

Latest patch is okay with me, too.  I must have missed the oldemailtech code
since I don't use it any more.

I thought putting the "New" in front would help to avoid confusing it as part
of the summary, but on the other hand it would mess up sorting the mailbox by
summary.  But then, maybe one day bug 31314 will be fixed and this won't matter
any more ...

Comment 17

[Chris Yeh]

r=cyeh

Comment 18

[Dave Miller [:justdave]]

Checked in.  Heads up, Barnboy, this needs to be release-noted.

CVS checkin comments:

UPGRADE NOTES: when you install this update, you will need to change the subject 
line in your 'changedmail' and 'newchangedmail' params from the web by running 
editparams.cgi. The subject line needs to be changed from:
Subject: [Bug %bugid%] %neworchanged% - %summary%
to
Subject: [Bug %bugid%] %neworchanged%%summary%

Or whatever is appropriate for the subject you are using on your system. Note the 
removal of the " - " in the middle. 

Comment 19

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product

Comment 20

[zhugh]

when I report the bug, and will report a mail to someone.
If the bug report have Chinese character, when receive the mail,the Chinese 
character will confusion,how can I add mail encode on the report mail?
I think the default encode shoule "UTF-8".

If you resolve this, please send the resolve  method to my 
mail:[e-mail]

Comment 21

[Dave Miller [:justdave]]

(In reply to comment #20)
> If the bug report have Chinese character, when receive the mail,the Chinese 
> character will confusion,how can I add mail encode on the report mail?

That has nothing to do with this bug.  That's bug 126266.

Comment 22

[zhugh]

(In reply to comment #21)
> That has nothing to do with this bug.  That's bug 126266.

How can I resolve that question?

Open CGI.pm and find the line
     $self->charset('');
and change to
     $self->charset('UTF-8');

can resolve it?
When I after save CGI.pm, then it will take effect?