Closed Bug 298260 Opened 19 years ago Closed 19 years ago

Support midl.exe with version == 6.00.0366 (included in latest MS Platform SDK)

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.8beta3

People

(Reporter: Waldo, Assigned: Waldo)

References

()

Details

Attachments

(1 file, 1 obsolete file)

The version of midl.exe included with the latest MS Platform SDK (the Windows
Server 2003 SP1 Platform SDK) is 6.00.0366, which isn't supported in
configure.in.    For those of us too poor to actually buy Microsoft's
development environment, this is the only version of midl.exe we have to make
builds using Microsoft's free C++ toolkit.  configure.in needs to be updated to
support midl version 6.00.0366.
note bug 249782 comment 30, and also note that the midl version from that patch
is the 3066 one
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → jwalden+bmo
Status: NEW → ASSIGNED
Attachment #186840 - Flags: review?(benjamin)
(In reply to comment #1)

I didn't read the comment before posting the patch.

That said, the URL is from a comment I got from a person who said he'd made this
change and compiled successfully, so if you're willing to believe him it does
work.  I'm just interested in keeping the number of hacks I have to make to my
tree to a minimum.
I don't doubt that this patch works. I just mentioned that bug because it
suggests that the check can maybe be removed.
Just remove the midl version check altogether since it predated the no-robust
check.
Attachment #186840 - Attachment is obsolete: true
Attachment #186989 - Flags: review?(benjamin)
Attachment #186989 - Flags: review?(benjamin)
Attachment #186989 - Flags: review+
Attachment #186989 - Flags: approval-aviary1.1a2+
Attachment #186840 - Flags: review?(benjamin)
The removal patch has been checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8beta3
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: