298545 - border-style: double displayed as solid

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Matt Bateman]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050619 Camino/0.9a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050619 Camino/0.9a1

In the page at http://www.the-undercurrent.com, for example, the border under
the links should be double. It's set to width 3px style double. But it shows up
as solid in Camino.

Reproducible: Always

Steps to Reproduce:
1. make a CSS element with border-style: double and sufficient width for this to
render
2. view the page in Camino
3. ponder the universe

Actual Results:  
It renders a solid border.

Expected Results:  
Render a double border.

Comment 1

[Samuel Sidler (old account; do not CC)]

Core bug. Checking for dupes before switching.

Comment 2

[Samuel Sidler (old account; do not CC)]

-> Core.

I'll create a testcase later. Also, if this is a dupe, I apologize. I couldn't
find it.

This *could* be poorly formed CSS but it does validate.

Comment 3

[Samuel Sidler (old account; do not CC)]

Attachment: Testcase

This seems only be a problem when border-width is defined. Otherwise,
border-style: double shows perfectly as demonstrated in this test case.

Comment 4

[Bernd]

is this a recent regression? On June 08 there went a fix in for bug 1781.

Comment 5

[Samuel Sidler (old account; do not CC)]

(In reply to comment #4)
> is this a recent regression? On June 08 there went a fix in for bug 1781.

Yes it did. This works in the 6/8 build of Camino but not in the 6/9 build.

Comment 6

[Felix Miata]

Broken on OS/2 & Linux current trunk too. Testcase upper p is thick solid in both.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

It must by my fault.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

ah, damn - it's such a trivial bug.
This patches fixes the testcase, URL, my internal testcases and
http://yano.jogger.pl/comment.php?eid=130987 .

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 188701 [details] [diff] [review]
patch

this trivial patch fixes regression with small widths in double borders.

Comment 10

[Sjoerd Visscher]

*** Bug 300890 has been marked as a duplicate of this bug. ***

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

*** Bug 301171 has been marked as a duplicate of this bug. ***

Comment 12

[Asa Dotzler [:asa]]

Who can land this for us? 

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Checking in nsCSSRendering.cpp;
/cvsroot/mozilla/layout/base/nsCSSRendering.cpp,v  <--  nsCSSRendering.cpp
new revision: 3.262; previous revision: 3.261
done

Comment 14

[Francesco Lodolo [:flod]]

The problem seems to be still present in Gran Paradiso alpha 4 on Mac Os X

Bottom and right borders of a button with border-style:double and border-width:3px are shown as solid. If you set a width and a height to the button double borders are ok.

Comment 15

[Zibi Braniecki [:zbraniecki][:gandalf]]

I don't have Mac OS X :(

I'll try to confirm that and reproduce it on other platforms.

Comment 16

[Francesco Lodolo [:flod]]

(In reply to comment #15)
> I don't have Mac OS X :(
> 
> I'll try to confirm that and reproduce it on other platforms.
> 

Sorry for my bad usage of BugZilla: I've already opened a new bug (I've been suggested that it's better than commenting a fixed bug) and discovered that this problem is solved in the latest nigthlies
https://bugzilla.mozilla.org/show_bug.cgi?id=379807