298648 - Implement ISimpleDOMNode::get_language()

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

We need a method to return the language of a DOM node.

I am purposely not revving the UUID for ISimpleDOMNode, but instead adding the
method to the end, because I want to avoid compatibility issues with current
impls that use ISimpleDOMNode.

Comment 1

[Aaron Leventhal]

Attachment: Implement get_language. I decided to rev the GUID for ISimpleDOMNode after all.

Comment 2

[timeless]

Comment on attachment 187185 [details] [diff] [review]
Implement get_language. I decided to rev the GUID for ISimpleDOMNode after all.

>@@ -131,12 +137,13 @@ import "oaidl.idl";
> const long DISPID_NODE_NODEINFO   = -5900;
> const long DISPID_NODE_ATTRIBUTES = -5901;
> const long DISPID_NODE_ATTRIBUTESFORNAMES = -5902;
> const long DISPID_NODE_COMPSTYLE  = -5903;
> const long DISPID_NODE_COMPSTYLEFORPROPS = -5904;
>+const long DISPID_NODE_LANGUAGE = -5905;

i noted that the code was aligning ='s, i don't care if it does or doesn't.

>Index: accessible/src/msaa/nsAccessNodeWrap.cpp
>+nsAccessNodeWrap::get_language(BSTR __RPC_FAR *aLanguage)
>+  *aLanguage = ::SysAllocString(language.get());

i think you should return E_OOM if this fails
>+  return S_OK;

Comment 3

[Aaron Leventhal]

Okay, I'll fix those thanks.

Comment 4

[Aaron Leventhal]

Comment on attachment 187185 [details] [diff] [review]
Implement get_language. I decided to rev the GUID for ISimpleDOMNode after all.

Bz is swamped. Roc?

Comment 5

[Aaron Leventhal]

Checking in accessible/public/msaa/ISimpleDOMNode.idl;
/cvsroot/mozilla/accessible/public/msaa/ISimpleDOMNode.idl,v  <-- 
ISimpleDOMNode.idl
new revision: 1.5; previous revision: 1.4
done
Checking in accessible/src/base/nsAccessibilityAtomList.h;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <-- 
nsAccessibilityAtomList.h
new revision: 1.27; previous revision: 1.26
done
Checking in accessible/src/msaa/nsAccessNodeWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessNodeWrap.cpp,v  <-- 
nsAccessNodeWrap.cpp
new revision: 1.17; previous revision: 1.16
done
Checking in accessible/src/msaa/nsAccessNodeWrap.h;
/cvsroot/mozilla/accessible/src/msaa/nsAccessNodeWrap.h,v  <--  nsAccessNodeWrap.h
new revision: 1.5; previous revision: 1.4
done