Closed
Bug 299084
Opened 20 years ago
Closed 20 years ago
cleanup nsBaseDragService::GetFrameFromNode()
Categories
(Core :: DOM: UI Events & Focus Handling, enhancement)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(1 file)
|
8.97 KB,
patch
|
roc
:
review+
roc
:
superreview+
roc
:
approval1.8b4-
|
Details | Diff | Splinter Review |
This is spawned from bug 289667 comment 9:
The only one remaining call to GetFrameFromNode() is in Mac specific code:
http://bonsai.mozilla.org/cvsblame.cgi?&file=/mozilla/widget/src/mac/nsDragService.cpp&root=/cvsroot&mark=130,161#129
Move it there and make it static...
|
Assignee | |
Comment 1•20 years ago
|
||
nsBaseDragService::mTransArray member can probably be removed as well.
http://lxr.mozilla.org/seamonkey/search?string=mTransArray
|
|
Assignee | |
Comment 2•20 years ago
|
||
Attachment #188742 -
Flags: superreview?(roc)
Attachment #188742 -
Flags: review?(roc)
Attachment #188742 -
Flags: superreview?(roc)
Attachment #188742 -
Flags: superreview+
Attachment #188742 -
Flags: review?(roc)
Attachment #188742 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #188742 -
Flags: approval1.8b4?
|
||
Comment 3•20 years ago
|
||
bz, can you take a quick look at this and let us know if you think it's worth
taking into the 1.8b4 release? Thanks.
Comment on attachment 188742 [details] [diff] [review]
Patch rev. 1
This may as well wait for 1.9.
Attachment #188742 -
Flags: approval1.8b4? → approval1.8b4-
|
||
Comment 5•20 years ago
|
||
Yeah, if we plan to branch Real Soon Now I'd hold this for 1.9...
|
|
Assignee | |
Comment 6•20 years ago
|
||
Checked in to trunk 2005-08-28 21:16 PDT
-> FIXED
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•