299112 - length value has wrapped in calculation (did you pass G_MAXLONG?)

Status: VERIFIED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Tuukka Tolvanen (sp3000)]

After update to gtk 2.6.8-1 (debian), getting spewage like:
    (thunderbird-bin:6212): Gdk-WARNING **: gdk_property_get(): length value has
wrapped in calculation (did you pass G_MAXLONG?)

http://lxr.mozilla.org/mozilla/source/gfx/src/gtk/nsScreenGtk.cpp#142
http://lxr.mozilla.org/mozilla/source/gfx/src/cairo/nsCairoScreen.cpp#135

    http://ftp.gnome.org/pub/GNOME/sources/gtk+/2.6/gtk+-2.6.8.changes
        2005-05-18  Matthias Clasen  <[e-mail]>
                * gdk/x11/gdkproperty-x11.c (gdk_property_get): Warn if
                length overflows.  (#161520, Ian Wienand)

http://developer.gnome.org/doc/API/gdk/gdk-properties-and-atoms.html#gdk-property-get

gdkproperty-x11.c:
  /* 
   * Round up length to next 4 byte value.  Some code is in the (bad?)
   * habit of passing G_MAXLONG as the length argument, causing an
   * overflow to negative on the add.  In this case, we clamp the
   * value to G_MAXLONG.
   */
  get_length = length + 3;
  if (get_length > G_MAXLONG)
    {
      g_warning ("gdk_property_get(): length value has wrapped in calculation "
		 "(did you pass G_MAXLONG?)");
      get_length = G_MAXLONG;
    }

Older gtk versions (e.g. 2.6.7) just used (length + 3) / 4 without checking...

Comment 1

[Tuukka Tolvanen (sp3000)]

Attachment: patch1: s/G_MAXLONG/G_MAXLONG - 3/

here's a nice and lame patch to use G_MAXLONG - 3 instead of G_MAXLONG, with a
comment.

Comment 2

[Tuukka Tolvanen (sp3000)]

checked in,
http://bonsai.mozilla.org/cvsquery.cgi?date=explicit&mindate=2005-07-03%2014:09&maxdate=2005-07-03%2014:09

Comment 3

[Jean-François Rameau]

*** Bug 298153 has been marked as a duplicate of this bug. ***

Comment 4

[Jan Schermer]

I'm having this problem with thunderbird-1.0.6
thunderbird spits
(thunderbird-bin:25868): Gdk-WARNING **: gdk_property_get(): length value has
wrapped in calculation (did you pass G_MAXLONG?)

and refuses to start (hangs)

please reopen this bug

Comment 5

[Tuukka Tolvanen (sp3000)]

> I'm having this problem with thunderbird-1.0.6

> please reopen this bug

no -- this bug is fixed on trunk for 1.1 and isn't a critical issue that
warrants fixing on the stable branch.