299221 - [CLEANUP] assign "isChar" inside gecko event conversion

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Josh Aas]

In widget/src/cocoa/nsChildView.mm, we use an outparameter for "isChar" in
cocoa->gecko event conversion. No need for this, so we should clean it up.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Asaf Romano (gone)]

Comment on attachment 187762 [details] [diff] [review]
fix v1.0

>Index: widget/src/cocoa/nsChildView.mm
>===================================================================

> - (void) convertKeyEvent:(NSEvent*)aKeyEvent message:(PRUint32)aMessage 
>-           isChar:(PRBool*)aIsChar
>-           toGeckoEvent:(nsKeyEvent*)outGeckoEvent
>+            toGeckoEvent:(nsKeyEvent*)outGeckoEvent

remove this indentation change. otherwise, r=mano.

Comment 3

[Josh Aas]

I'll get rid of that when I land - it looked different in my editor for some
reason...

Comment 4

[Mike Pinkerton (not reading bugmail)]

the better question is "why was it there in the first place?" Is it something we
should be using, rather than removing?

Comment 5

[Simon Fraser [no longer active]]

This patch has the effect of setting isChar on the gecko event for keyUp events,
when it was not set before. Note tha the keyUp: method didn't assign isChar to
geckoEvent.isChar.

Comment 6

[Josh Aas]

Attachment: fix v1.1

sets isChar to PR_FALSE in keyUp

Comment 7

[Simon Fraser [no longer active]]

Actually the first patch does the right thing; looking at the carbon code, we
only want to set isChar for some KEY_PRESS events, and never KEY_UP or KEY_DOWN.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 187852 [details] [diff] [review]
fix v1.1

well then...

Comment 9

[Josh Aas]

fix v1.0 landed on trunk