Closed
Bug 299268
Opened 21 years ago
Closed 21 years ago
<iframe> fails to open the body automatically
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file, 1 obsolete file)
|
3.79 KB,
patch
|
jst
:
review+
jst
:
superreview+
asa
:
approval1.8b3+
|
Details | Diff | Splinter Review |
As pointed out in bug 289537 comment 21, <iframe> does not open a <body>
automatically. I should have tested instead of just trusting nsElementTable.
As a note: I cannot make <input type=hidden> open a body automatically as
requested in bug 289537 comment 21 because it would regress bug 66985 (which has
a couple of dupes).
|
Assignee | |
Comment 1•21 years ago
|
||
The early return was preventing us from falling through and opening the
requested body. This patch fixes that.
Assignee: parser → mrbkap
Status: NEW → ASSIGNED
Attachment #187832 -
Flags: superreview?(jst)
Attachment #187832 -
Flags: review?(jst)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 187832 [details] [diff] [review]
fix iframe
r+sr=jst
Attachment #187832 -
Flags: superreview?(jst)
Attachment #187832 -
Flags: superreview+
Attachment #187832 -
Flags: review?(jst)
Attachment #187832 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
This patch as it stands will regress bug 288991. I want to check this patch in
(for correctness), but I need to change the element table to not open a body for
<iframe> to avoid regerssing the other bug. Sorry Martijn.
|
|
Assignee | |
Comment 4•21 years ago
|
||
Comment on attachment 187832 [details] [diff] [review]
fix iframe
Marking r- so I don't confuse myself.
Attachment #187832 -
Flags: superreview+
Attachment #187832 -
Flags: review-
Attachment #187832 -
Flags: review+
|
|
Assignee | |
Comment 5•21 years ago
|
||
This is the same as patch v1, except that it makes <iframe> not require a body.
Attachment #187832 -
Attachment is obsolete: true
Attachment #187951 -
Flags: superreview?(jst)
Attachment #187951 -
Flags: review?(jst)
|
|
||
Comment 6•21 years ago
|
||
Comment on attachment 187951 [details] [diff] [review]
patch v2
r+sr=jst
Attachment #187951 -
Flags: superreview?(jst)
Attachment #187951 -
Flags: superreview+
Attachment #187951 -
Flags: review?(jst)
Attachment #187951 -
Flags: review+
|
|
Assignee | |
Comment 7•21 years ago
|
||
Comment on attachment 187951 [details] [diff] [review]
patch v2
This is a very safe patch to make some code in the HTML parser more predictable
in how it acts.
Attachment #187951 -
Flags: approval1.8b3?
|
||
Updated•21 years ago
|
Attachment #187951 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 8•21 years ago
|
||
Fix checked in earlier today.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•