299444 - Opening links from other applications in a new tab does not work anymore

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Sven Grull]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050701
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050701

Opening links from other applications in a new tab does not work anymore.
Every time I open a link from another application Mozilla opens a new window
instead of opening a new tab in the current window as selected in the
preferences. The same happens when I switch to open links from other
applications in the current window/tab.
This seems to be Mozilla specific as it still works in Firefox trunk builds.

Reproducible: Always

Comment 1

[Timothy B. Anderson (Tails)]

Build: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050702

I can reproduce this bug in the nightly trunk build above.

Comment 2

[Jason Bassford]

This was never actually completely fixed - which is why I reopened bug 121969. 
However, up until about a week ago a workaround was to use the "singlewindow"
extension.  That no longer works.  So something has definitely got worse.

Comment 3

[Hermann Schwab]

Also seen in Build ID: 2005062905
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050629
Maybe the component is XP Apps?

Comment 4

[Jason Bassford]

*** Bug 299983 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel Veditz [:dveditz]]

This probably regressed due to bug 298255

Comment 6

[Jason Bassford]

*** Bug 300171 has been marked as a duplicate of this bug. ***

Comment 7

[Andrew Schultz]

Attachment: patch

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 188778 [details] [diff] [review]
patch

Argh, I caught that, patched it, and then didn't check in! diff is still in my
tree.
sr=dveditz

Comment 9

[Daniel Veditz [:dveditz]]

Fix checked in

Comment 10

[[e-mail]]

Comment on attachment 188778 [details] [diff] [review]
patch

>     var loadflags = isExternal ?
>-                      nsCI.nsIWebNavigation.LOAD_FLAGS_FROM_EXTERNAL :
>-                      nsCI.nsIWebNavigation.LOAD_FLAGS_NONE;
>+                      Components.interfaces.nsIWebNavigation.LOAD_FLAGS_FROM_EXTERNAL :
>+                      Components.interfaces.nsIWebNavigation.LOAD_FLAGS_NONE;
Looks like dveditz checked this in without the unnecessary
Components.interfaces. prefix (the const is in browser.js).

Comment 11

[Sven Grull]

Reopening - tinderbox build 2005070923
Using the latest SeaMonkey build this is still not fixed for me. Links from an
external application are still opened in a new window.

Comment 12

[Jason Bassford]

Agreed.  A 7/10-04 build still fails.

Comment 13

[Andrew Schultz]

Attachment: patch

Opening in the same browser window (not a new tab) was still broken and this
patch fixes that.  With this patch, everything works properly for me -- the
code I'm patching works and the (linux-specific) code that calls it also works.


is there any reason not to pass the referer?

If you're still having problems opening in a new tab, this patch won't fix it
and you should file a new bug with detailed steps to reproduce so someone can
fix what you're seeing.

Comment 14

[[e-mail]]

Comment on attachment 188847 [details] [diff] [review]
patch

I think what attachment 188778 [details] [diff] [review] actually fixed was bug 299983 (although I
haven't checked this). This is probably a separate bug caused by my not
implementing all the pieces of the preference. I'll have to go back and see
what I missed.

(In reply to comment #13)
>is there any reason not to pass the referer?
Because if there's no opener then there's no referrer.

Comment 15

[Robby Duran]

I'm happy to report that opening links from other applications in a new tab in
current window worked fine with both build (20050710) currently i've tested.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050710
SeaMonkey/1.0a Build ID : 2005071005 and 2005071014

Comment 16

[Andrew Schultz]

Attachment: patch without referer

Comment 17

[[e-mail]]

Comment on attachment 188900 [details] [diff] [review]
patch without referer

Duplicate of attachment 188778 [details] [diff] [review]

Comment 18

[Andrew Schultz]

Attachment: the real patch

oops

Comment 19

[[e-mail]]

Comment on attachment 188937 [details] [diff] [review]
the real patch

Oh, I get the point now, thanks.

Comment 20

[Andrew Schultz]

Comment on attachment 188937 [details] [diff] [review]
the real patch

this is 100% seamonkey code

Comment 21

[Andrew Schultz]

Comment on attachment 188937 [details] [diff] [review]
the real patch

this is in
this is FIXED

if you are still seeing symptoms of this bug, please file a new bug and provide
reproducible steps to trigger the bug.