Closed
Bug 299575
Opened 20 years ago
Closed 20 years ago
nsDocumentViewer.cpp:1329 unused variable `PRBool updateHistory'
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bastiaan, Assigned: bastiaan)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 1 obsolete file)
|
657 bytes,
patch
|
bastiaan
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
I'm guessing the original author created the variable but then figured it would
be easier to check mSHEntry directly.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #188139 -
Flags: superreview?(bryner)
Attachment #188139 -
Flags: review?(bryner)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 188139 [details] [diff] [review]
removes unused var, adds null check
This whole block is |if (mSHEntry)|, so I don't see a need to check it again.
r+sr=me on removing the unused variable though.
Attachment #188139 -
Flags: superreview?(bryner)
Attachment #188139 -
Flags: superreview+
Attachment #188139 -
Flags: review?(bryner)
Attachment #188139 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
(In reply to comment #2)
> This whole block is |if (mSHEntry)|, so I don't see a need to check it again.
Indeed, I overlooked the indentation.
Attachment #188139 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Blocks: buildwarning
|
|
Assignee | |
Comment 4•20 years ago
|
||
Comment on attachment 188150 [details] [diff] [review]
remove null check
citing r+sr=bryner
Attachment #188150 -
Flags: review+
Attachment #188150 -
Flags: approval1.8b4?
|
||
Updated•20 years ago
|
Attachment #188150 -
Flags: approval1.8b4? → approval1.8b4+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Checked in by timeless (2005-07-13 11:23).
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•