299639 - locally declared functions don't take precedence over parameters of the same name.

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[mozilla]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.4; Linux) KHTML/3.4.0 (like Gecko)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.6)



Reproducible: Always

Comment 1

[mozilla]

hit <Enter> a little bit too early... 
According to the Ecmascript spec (section 10.1.3) locally declared functions 
should take precedence over parameters. 

Comment 2

[mozilla]

Attachment: test-case, where a parameter takes precedence over a locally declared function.

the test-case should print the function, and not the parameter.

Comment 3

[Brendan Eich [:brendan]]

Attachment: simple fix: override hidden arg with local var for JSOP_DEFLOCALFUN

This leaves the argv slot inaccessible, but it's a hard case, and who cares in
light of the code size savings of this approach, as opposed to adding some
variant of JSOP_DEFLOCALFUN that uses a fp->argv instead of fp->vars slot.

/be

Comment 4

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 188957 [details] [diff] [review]
simple fix: override hidden arg with local var for JSOP_DEFLOCALFUN

r=shaver, let's get a test in the suite too.

Comment 5

[Brendan Eich [:brendan]]

Bob always does, no need to nag ;-P.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to comment #4)
> (From update of attachment 188957 [details] [diff] [review] [edit])
> r=shaver, let's get a test in the suite too.

set testcase? flag to make sure I don't forget.

Comment 7

[Brendan Eich [:brendan]]

Comment on attachment 188957 [details] [diff] [review]
simple fix: override hidden arg with local var for JSOP_DEFLOCALFUN

Self-approving, this is a straightforward spot-fix.

/be

Comment 8

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 9

[Caleb]

This was backed out.. don't forget to check it in again ;-)

Comment 10

[Bob Clary [:bc] (inactive)]

(In reply to comment #9)
> This was backed out.. don't forget to check it in again ;-)

Caleb, can you point me to the bug where this was done?

Comment 11

[Brendan Eich [:brendan]]

Only record of it was in CVS, on bonsai from tinderbox.  I got a "you're off the
hook" tree open email, and checked in.  Chase asked me to back out, cuz he had
to respin a few builds from the trunk.

Reopening so everyone can see the fixes go in again tomorrow.

/be

Comment 12

[Brendan Eich [:brendan]]

Fixed.

/be

Comment 13

[Bob Clary [:bc] (inactive)]

Checking in 10.1.3-2.js;
/cvsroot/mozilla/js/tests/ecma/ExecutionContexts/10.1.3-2.js,v  <--  10.1.3-2.js
initial revision: 1.1

Comment 14

[Bob Clary [:bc] (inactive)]

verified fixed 20060401 1.8.0.2, 1.8, 1.9a1 win/mac/linux