299999 - Talkback extension needs an install.rdf

Status: RESOLVED FIXED

(Core Graveyard :: Talkback Client, defect)

Description

[Dave Townsend [:mossop]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050707 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050707 Firefox/1.0+

Now the talkback client is installed as an extension it needs an install.rdf so
the extension manager can recognise it.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Jay Patel [:jay]]

Not sure who is driving this, but I definitely don't know enough about making
Talkback an extension to own this bug.  Darin?

Comment 2

[Darin Fisher]

-> chase, who's working on the fix for this.  this bug explains why talkback
does not work on the trunk.

Comment 3

[chris hofmann]

this should block alpha2, right?

Comment 4

[Chase Phillips]

Yes.

Comment 5

[Chase Phillips]

I have a fix for getting install.rdf placed in the
extensions/[e-mail]/ directory checked in.  I'm sorting out a
Linux-related Talkback issue right now and will respin in the next 30 minutes or so.

Comment 6

[Bill Gianopoulos [:WG9s]]

Will this fix the issue of the automatic update doingan update of a talkback
enabled build but the end result not being talkback enabled?  If not, should I
file a seperate bug on that?

Comment 7

[Bill Gianopoulos [:WG9s]]

(In reply to comment #6)
> Will this fix the issue of the automatic update doingan update of a talkback
> enabled build but the end result not being talkback enabled?  If not, should I
> file a seperate bug on that?

It appears this may be a non-issue.  It appears that the latest Firfox nightly
(2005070717) was not built with talkback, so I updated to a build without talkback.

Comment 8

[Chase Phillips]

Okay, I think I have the issues sorted.  Thanks to Darin, Jay, and Bryner for
their feedback today.  I'm doing Firefox trunk respins to ensure that the
appropriate fixes make it into the Linux, Windows, and Mac builds.  If we verify
those fixes the release builds tomorrow for Thunderbird should automatically
pick up the fixes.

Comment 9

[Bill Gianopoulos [:WG9s]]

This is still not quite right.  The 2005070719 windows build appears to include
talkback (at least the size of the installer .exe file would indicate as much)
but talkback does not launch when firefox crashes.

Comment 10

[Chase Phillips]

The Talkback extension's install.rdf is missing from the packages-static files,
as is now evident from the patch I created and landed.

Had I realized shuffling Talkback into its own extension would've gotten to be
such a big change I would've preferred we wait until after alpha2 to do it. 
There is hope, though, as backing out is still available as an option.  Either
my next fix will resolve this or I'll revert things back to how they were
earlier this week.

Comment 11

[Chase Phillips]

Attachment: Add install.rdf to packages-static for browser and mail

r+sr+a=chase

Comment 12

[Chase Phillips]

Comment on attachment 188624 [details] [diff] [review]
Add install.rdf to packages-static for browser and mail

Checking in browser/installer/windows/packages-static;
/cvsroot/mozilla/browser/installer/windows/packages-static,v  <-- 
packages-static
new revision: 1.52; previous revision: 1.51
done
Checking in browser/installer/unix/packages-static;
/cvsroot/mozilla/browser/installer/unix/packages-static,v  <--	packages-static
new revision: 1.49; previous revision: 1.48
done
Checking in mail/installer/windows/packages-static;
/cvsroot/mozilla/mail/installer/windows/packages-static,v  <--	packages-static
new revision: 1.2; previous revision: 1.1
done

Comment 13

[Caleb]

I get this in the EM:
Talkback - not compatible with Deer Park 1.0+

The install.rdf says:
        <em:minVersion>@FIREFOX_VERSION@</em:minVersion>
        <em:maxVersion>@FIREFOX_VERSION@</em:maxVersion>

Comment 14

[Bill Gianopoulos [:WG9s]]

(In reply to comment #13)
> I get this in the EM:
> Talkback - not compatible with Deer Park 1.0+
> 
> The install.rdf says:
>         <em:minVersion>@FIREFOX_VERSION@</em:minVersion>
>         <em:maxVersion>@FIREFOX_VERSION@</em:maxVersion>

This is not the entire issue either.  I uninstalled Dear Park Alpha 2, removed
the entire c:/Program Files/Deer Park Alpha 2 folder and contents and then
re-installed the 2005070806 build.  Before launching I hand edited the
install.rdf to correct the min and max version numbers to be 1.0+.

Then I launched Firefox, and lo and behold, the talkback extenion was enabled. :-)

Now for the bad news.

I forced Firefox to crash (by excersizing bug 300039) and Talkback did not
launch. :-(

Comment 15

[Grayson Mixon (ColdFusion650)]

i hard coded in 1.0+ into install.rdf and its still disabled for me.

Comment 16

[Dave Townsend [:mossop]]

Talkback is still not being installed with the installer for me.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
Firefox/1.0+ ID:2005070807

Comment 17

[Darin Fisher]

Using this morning's Firefox nightly build on Windows, I hand edited talkback's
install.rdf to change @FIREFOX_VERSION@ to 1.0+, and then I used the testcase in
bug 282707 to successfully submit a crash report to talkback.  I think the only
remaining problem therefore is that the install.rdf needs to be fixed.

This should be easy for someone at the Mozilla Foundation, with access to the
talkback source, to fix.

Comment 18

[Grayson Mixon (ColdFusion650)]

did yall do something? wfm now.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
Firefox/1.0+ ID:2005070810

Comment 19

[Chase Phillips]

(In reply to comment #18)
> did yall do something? wfm now.
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
> Firefox/1.0+ ID:2005070810

Yes, install.rdf was missing the keywords needed to signal the preprocessor.  I
added those and did respins.  Win/Mac are out.  Linux is nearly out.

Comment 20

[Caleb]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
Firefox/1.0+ ID:2005070810

Downloaded the build from here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005-07-08-10-trunk/ (URL
given by Chase).

Extracted to a clean folder, ran it with a dirty profile.
Talkback registers itself properly in the EM and pops up upon crash.

So it seems to be working properly on Windows.

Comment 21

[Bill Gianopoulos [:WG9s]]

(In reply to comment #14)
> 
> Now for the bad news.
> 
> I forced Firefox to crash (by excersizing bug 300039) and Talkback did not
> launch. :-(

I retested using the 2005070810 build and talkback installed correctly without
the need of any install.rdf editing and used the same procedure to crash
Firefox. Talkback launched correctly and I was able to sent the talkback incident.

So I am verfying that it is fixed for windows.

Comment 22

[Chase Phillips]

->FIXED

Comment 23

[Jay Patel [:jay]]

I verified that Talkback is working with this morning's Linux Deer Park build
20050708.

Comment 24

[Bryan]

When I click on Help-> Launch Talkback.  I get a dialog that states "Alert:
Could not find talkback.  Perhaps it isn't installed."  I can however navigate
to "C:\Program Files\Firefox\extensions\[e-mail]\components" and
MANUALLY launch talkback.exe myself.

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050708
Firefox/1.0+ ID:2005070808

Can we fix this?

Comment 25

[Benjamin Smedberg]

Help -> Launch Talkback is not one of our default menu items. Did you get an
extension which shows that menu?