Closed Bug 300011 Opened 19 years ago Closed 19 years ago

Plugin's WINCE fix up

Categories

(Core Graveyard :: Plug-ins, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

I have been having problems with some of the code in plugins:

http://weblogs.mozillazine.org/dougt/archives/008381.html

Basically, function pointer addresses do not work as expected using the clarm
compiler for windows ce.  

Looking at the subclassing we are doing, I am not sure that the WindowCE
implementation needs to to handle any of the cases that the desktop had to
including popup blocking, mouse tracking, or noisy plugins.
Attached patch patch v.1Splinter Review
This patch disables plugin window subclassing for WINCE.  
Since we do not have a default plugin, I have disabled that as well.
Attachment #188593 - Flags: review?(jst)
Comment on attachment 188593 [details] [diff] [review]
patch v.1

Please add a comment explaining why we don't want to subclass windows on WINCE,
and reference this bug.

r+sr=jst
Attachment #188593 - Flags: superreview+
Attachment #188593 - Flags: review?(jst)
Attachment #188593 - Flags: review+
Checking in nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <-- 
nsPluginHostImpl.cpp
new revision: 1.526; previous revision: 1.525
done
Checking in nsPluginNativeWindowWin.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginNativeWindowWin.cpp,v  <-- 
nsPluginNativeWindowWin.cpp
new revision: 1.13; previous revision: 1.12
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee: nobody → doug.turner
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: