300025 - editline can add non-unique lines to history

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

I tracked down a newer version of editline than the one we use, and after
reading the diffs between the newer version and our version it became apparent
that the only real differences were:
- mccabe removed the tab-completion stuff. Bringing it back now seems pointless.
- a potential crash fix if tgetstr() returned NULL. I'll slip that into this
patch for completeness.
- by going back in history and typing the last line in history, it is possible
to add non-unique entries to the line history back-to-back. The fix is fairly
trivial.

Unfortunately, there weren't any fixes for the wrapping problem that Brendan and
I both see. I may take a crack at that to see if I can dig anything up, later.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 188608 [details] [diff] [review]
patch v1

Strictly, you know, this doesn't prevent non-unique lines.  Just non-unique
_consecutive_ lines.  I'll let you off with a warning, though.

r=shaver

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.