300105 - The found link doesn't have pseudo-focus in FAYT on frame page

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

1. See http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2850&action=view
2. Type "'"
3. Type"f"

In this case, FAYT found the link in inner frame. But the found link didn't have
the pseudo-focus.

If after to click the document, FAYT set the pseudo-focus to the found link.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

 Is there ever a case when the mPresContext will be null?

Also, if this is a Core bug (which it is), please move it to Core.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

> Is there ever a case when the mPresContext will be null?

I don't know. It's safety code.
Should I remove it?

Comment 4

[Boris Zbarsky [:bzbarsky]]

If you're not hitting cases when it's null, then yes.  I don't see how such
cases could reasonably arise.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.1

O.K. I cannot find mPresContext is null in my test.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Attachment: Patch rv1.2

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

Comment on attachment 188857 [details] [diff] [review]
Patch rv1.2

The risk is low.
I think it is important bug for FAYT.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sick)]

checked-in.

Comment 9

[Travis Hume]

Thank you!  Working well here.