Closed
Bug 300335
Opened 20 years ago
Closed 20 years ago
Invalid write in get_current_cs
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
VERIFIED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
Attachments
(1 file)
|
999 bytes,
patch
|
mscott
:
review+
mscott
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
get_current_cs allocates ccs to be of size 0xff (255)
215 ccs = (struct cs_info *) malloc(0xff * sizeof(cs_info));
and then attempts to initialize the 0xff element
244 for (i = 0x00; i <= 0xff ; ++i) {
245 ccs[i].cupper = upper[i];
|
Assignee | |
Updated•20 years ago
|
Flags: blocking1.8b4?
|
||
Comment 1•20 years ago
|
||
Without further information about this problem, it's not going to block our
release. please renominate if you can tell us why this should block. Thanks.
Flags: blocking1.8b4? → blocking1.8b4-
|
|
Assignee | |
Comment 2•20 years ago
|
||
Attachment #190204 -
Flags: superreview?(mscott)
Attachment #190204 -
Flags: review?(mscott)
|
|
Assignee | |
Updated•20 years ago
|
Assignee: mscott → ajschult
|
||
Updated•20 years ago
|
Attachment #190204 -
Flags: superreview?(mscott)
Attachment #190204 -
Flags: superreview+
Attachment #190204 -
Flags: review?(mscott)
Attachment #190204 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 190204 [details] [diff] [review]
patch
low risk patch to make us stop stomping on memory we don't own
Attachment #190204 -
Flags: approval1.8b4?
|
||
Updated•20 years ago
|
Attachment #190204 -
Flags: approval1.8b4? → approval1.8b4+
|
||
Comment 4•20 years ago
|
||
Checking in extensions/spellcheck/myspell/src/csutil.cpp;
/cvsroot/mozilla/extensions/spellcheck/myspell/src/csutil.cpp,v <-- csutil.cpp
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•