300491 - pango changes require to work with gtk 2.7 (cairo)

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Christopher Blizzard (:blizzard)]

Gtk 2.7 uses cairo for rendering and the the current pango code assumes that
that the xft context is being used.  Some small changes are required.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: update pango code to handle a cairo context

Comment 2

[Dennis Jacobfeuerborn]

This makes the  nightly builds unusable when running on Fedora Rawhide.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 189058 [details] [diff] [review]
update pango code to handle a cairo context

r=caillon.  roc, what say ye?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 189058 [details] [diff] [review]
update pango code to handle a cairo context

Needed lest we don't work with GTK+ >= 2.7

Comment 5

[Dennis Jacobfeuerborn]

Given the current schedule of 1.5 and 2.0 and Fedoras six month release cycle
doesn't the "-" amount to the fact that the then current official Mozilla
release of Firefox 1.5 will be incompatible with the final release of Fedora
Core 5 when it is released?

Comment 6

[Christopher Blizzard (:blizzard)]

Fixed.

Comment 7

[Dennis Jacobfeuerborn]

Attachment: Dialogs without text

Some dialogs are still broken after this was checked in: Mozilla/5.0 (X11; U;
Linux i686; en-US; rv:1.8b4) Gecko/20050726 Firefox/1.0+

I'm posting this from the current Rawhide build in which the dialogs work but
there are other issues (startup and font rendering): Mozilla/5.0 (X11; U; Linux
i686; en-US; rv:1.8b3) Gecko/20050723 Fedora/1.1-0.2.4.deerpark.alpha2
Firefox/1.0+

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Rawhide is using the exact same patch that was checked in.  Make sure you
rebuilt and exit all firefox processes.

Comment 9

[Dennis Jacobfeuerborn]

(In reply to comment #8)
> Rawhide is using the exact same patch that was checked in.  Make sure you
> rebuilt and exit all firefox processes.

I figured you'd use the same patch for the Rawhide release which is why I'm a
bit puzzled about this. I even rebooted the machine and started firefox with a
fresh profile but the problem still remains.

Comment 10

[Dennis Jacobfeuerborn]

Things have gotten worse with todays Rawhide update to gtk2-2.7.4, cairo-0.6.0
and pango-1.9.1 because now as soon as I see the save dialog pop up Firefox just
crashes.

Comment 11

[Dennis Jacobfeuerborn]

With build Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050801
Firefox/1.0+ I get the following error when starting firefox (after updating to
todays Rawhide):

firefox-bin: cairo-xlib-surface.c:1883: _xlib_glyphset_cache_create_entry:
Assertion `NOT_REACHED' failed.
./run-mozilla.sh: line 131:  2948 Aborted                 "$prog" ${1+"$@"}

Comment 12

[Dennis Jacobfeuerborn]

Let me clarify: I get the error mentioned in my last comment when I try to save
an image or a page, not on the actual startup of firefox. Sorry for the confusion.