301340 - js.obj : error LNK2019: unresolved external symbol _js_GetDependentStringChars referenced in function _Evaluate

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

narcissus doesn't build on windows because mrbkap entrailed a js private
function (js_GetDependentStringChars) using a js macro (JSSTRING_CHARS) in
jsshell (Evaluate) which is an embedding consumer.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: use public apis

timeless was concerned about JS_GetStringChars returning NULL, but I don't
think that source can be a dependent string, so JS_GetStringChars shouldn't
need to allocate anything and we should be safe.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 189807 [details] [diff] [review]
use public apis

Brendan says r=him.

Comment 3

[Brendan Eich [:brendan]]

Furthermore (timeless!), JS_GetStringChars never returns null.  If there's an
OOM it returns a pointer into the dependent string's base string's chars, which
lacks only a NUL backstop terminator.

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 189807 [details] [diff] [review]
use public apis

So this is not part of the build (unlike xpcshell), but a=me anyway -- get it
in so we can all move on ;-).

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Checked in.